Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docker-publish-release to not trigger on pull requests #822

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Update docker-publish-release to not trigger on pull requests #822

merged 1 commit into from
Oct 23, 2024

Conversation

pschork
Copy link
Contributor

@pschork pschork commented Oct 19, 2024

Also triggers, but does not publish, on merge to master

Why are these changes needed?

Should not run on pull request

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@pschork
Update docker-publish-release to not trigger on pull requests
0889327 
Runs but does not publish on merge to master
@pschork pschork requested a review from samlaf October 19, 2024 21:14
@pschork pschork merged commit 34034f4 into master Oct 23, 2024
10 checks passed
@pschork pschork deleted the pschork/docker_release_update branch November 5, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jianoaix jianoaix jianoaix approved these changes

@samlaf samlaf Awaiting requested review from samlaf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pschork @jianoaix