ci: add eigenda-client testnet-integration test to integration-tests.yml workflow #820
Conversation
| @@ -79,6 +79,9 @@ jobs: | |||
| - name: Node Plugin | |||
| run: go test -v ./node/plugin/tests | |||
|
|
|||
| - name: eigenda-client | |||
There was a problem hiding this comment.
How long does it take to run? If too slow, we may only run it on master branch i.e. when PR is merged.
There was a problem hiding this comment.
hmm depends on batcher basically. batching interval is 10 mins on holesky testnet right now?
I think we should remove waiting for finalization.. that's just dumb to test I feel, and adds a 12 minute interval. And its testing the disperser itself more so than the client.
There was a problem hiding this comment.
set waitForFinalization=false: eca995e
Ran locally and it took <2mins. Let's see here. Think it depends on when in batching interval we send the request, but should hopefully be < 10 mins otherwise we'll need to increase default 10min golang test limit just for this test.
Why are these changes needed?
Not sure if this was not included on purpose (possible since this test might take a while to run? depending on batching interval on testnet), but added in case.
Checks