Protobufs for the relay #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cody Littley <[email protected]>
Signed-off-by: Cody Littley <[email protected]>
Signed-off-by: Cody Littley <[email protected]>
ian-shim
reviewed
Oct 16, 2024
api/proto/relay/relay.proto
Outdated
| // The chunk requested. | ||
| common.ChunkData chunk = 1; | ||
| // The error that occurred while trying to fetch a blob or chunks. | ||
| enum RelayError { |
There was a problem hiding this comment.
Should we make the RelayError class a combination of an enum field + a string field for error message? Having error message will be helpful for 1) providing detailed error message, 2) representing more granular errors within error code
There was a problem hiding this comment.
Makes sense. Done.
Signed-off-by: Cody Littley <[email protected]>
ian-shim
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR adds protobufs for the relay. WIP.
Checks