Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds subgraph indexing of ejection manager events #798

Merged
merged 3 commits into from
Oct 11, 2024

Conversation

pschork
Copy link
Contributor

@pschork pschork commented Oct 10, 2024

Why are these changes needed?

Subgraph indexing of ejection events

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@pschork pschork requested a review from dmanc October 10, 2024 00:44
Copy link
Contributor

@dmanc dmanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

subgraphs/eigenda-ejection-manager/alchemy.md Outdated Show resolved Hide resolved
Abstract networks to handle lack of preprod-holesky support on graph cli
@pschork pschork marked this pull request as ready for review October 11, 2024 00:25
Copy link
Contributor

@hopeyen hopeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. The subgraph is very simple but wondering if there should be any unit tests

@pschork pschork merged commit f5a3c52 into master Oct 11, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants