Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataApi] Add Service Availability Handler #276

Merged
merged 26 commits into from
Mar 8, 2024

Conversation

siddimore
Copy link
Contributor

@siddimore siddimore commented Feb 23, 2024

Why are these changes needed?

Expose Service Availability for Disperser and Churner.

Synthetic Check

Once this change is deployed Synthetic check can be run as below:

Preprod deployment

Screenshot 2024-03-07 at 11 47 51 AM

Disperser

  • Serving
    query: /v1/eigenda/service-availability?service-name=disperser
    Response:
    {ServiceName: "Disperser", ServiceStatus: "SERVING"} with status_code: 200
  • Not Serving
    query: /v1/eigenda/service-availability?service-name=disperser
    Response:
    {ServiceName: "Disperser", ServiceStatus: "NOT_SERVING"} with status_code: 503

Churner

  • Serving
    query: /v1/eigenda/service-availability?service-name=churner
    Response:
    {ServiceName: "Churner", ServiceStatus: "SERVING"} with status_code: 200
  • Not Serving
    query: /v1/eigenda/service-availability?service-name=churner
    Response:
    {ServiceName: "Churner", ServiceStatus: "NOT_SERVING"} with status_code: 503

Both

  • Serving
    query: /v1/eigenda/service-availability
    Response:
    [{ServiceName: "Disperser", ServiceStatus: "SERVING"}, {ServiceName: "Churner", ServiceStatus: "SERVING"}] with status_code: 200

Change

  1. Implement endpoint for EigenDA public Service
  2. Add Handler for getting Service Status
  3. Create GRPC pool of connections for faster access
  4. Check GRPC Health of Server by calling endpoints:
    // disperser-goerli.eigenda.eigenops.xyz,
    // churner-goerli.eigenda.eigenops.xyz

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@siddimore siddimore requested review from jianoaix and dmanc February 23, 2024 15:46
@siddimore siddimore changed the title [DataApi] Add EigenDA Service Availability Handler [DataApi] Add Service Availability Handler Feb 23, 2024
disperser/cmd/dataapi/flags/flags.go Outdated Show resolved Hide resolved
disperser/dataapi/server.go Outdated Show resolved Hide resolved
disperser/dataapi/server.go Show resolved Hide resolved
@siddimore siddimore marked this pull request as ready for review February 25, 2024 23:09
disperser/dataapi/server.go Outdated Show resolved Hide resolved
disperser/dataapi/service_availability_handler.go Outdated Show resolved Hide resolved
disperser/dataapi/service_availability_handler.go Outdated Show resolved Hide resolved
disperser/dataapi/server.go Outdated Show resolved Hide resolved
disperser/dataapi/service_availability_handler.go Outdated Show resolved Hide resolved
disperser/dataapi/service_availability_handler.go Outdated Show resolved Hide resolved
@siddimore siddimore merged commit e903682 into Layr-Labs:master Mar 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants