Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[disperser] More security params validation #22

Merged
merged 1 commit into from
Nov 14, 2023
Merged

[disperser] More security params validation #22

merged 1 commit into from
Nov 14, 2023

Conversation

ian-shim
Copy link
Contributor

Why are these changes needed?

  • Length of security params should not exceed 255
  • There shouldn't be any duplicate quorums in the list

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@ian-shim ian-shim marked this pull request as ready for review November 14, 2023 05:33
@ian-shim ian-shim changed the title more security params validation [disperser] More security params validation Nov 14, 2023
@ian-shim ian-shim merged commit 323132e into Layr-Labs:master Nov 14, 2023
3 of 4 checks passed
teddyknox pushed a commit that referenced this pull request Nov 16, 2023
@gpsanant
dataStore -> batch (#22)
f43bf39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jianoaix jianoaix jianoaix approved these changes

@mooselumph mooselumph Awaiting requested review from mooselumph

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ian-shim @jianoaix