Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[finalizer] Create new ctx for every retry #18

Merged
merged 1 commit into from
Nov 14, 2023
Merged

[finalizer] Create new ctx for every retry #18

merged 1 commit into from
Nov 14, 2023

Conversation

ian-shim
Copy link
Contributor

@ian-shim ian-shim commented Nov 14, 2023

Why are these changes needed?

Reusing a context that has already timed out causes all retry attempts to fail.
This PR makes it create new context with timeout for every retry attempt.

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@ian-shim ian-shim marked this pull request as ready for review November 14, 2023 02:37
@ian-shim ian-shim merged commit 324f90b into Layr-Labs:master Nov 14, 2023
5 checks passed
hopeyen pushed a commit that referenced this pull request Sep 18, 2024
Add support for native L2-L3 bridging of the fee token
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants