Skip to content

Commit

Permalink
update comments
Browse files Browse the repository at this point in the history
  • Loading branch information
ian-shim committed May 31, 2024
1 parent cc369c5 commit 3056bcc
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
5 changes: 2 additions & 3 deletions core/aggregation.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,12 @@ type SigningMessage struct {
}

// QuorumAttestation contains the results of aggregating signatures from a set of operators by quorums
// It also returns map of all signers across all quorums
type QuorumAttestation struct {
// QuorumAggPubKeys contains the aggregated public keys for all of the operators each quorum,
// including those that did not sign
QuorumAggPubKey map[QuorumID]*G1Point
// SignersAggPubKey is the aggregated public key for all of the operators that signed the message for each quorum,
// further aggregated across the quorums; operators signing for multiple quorums will be included in
// the aggregation multiple times
// SignersAggPubKey is the aggregated public key for all of the operators that signed the message by each quorum
SignersAggPubKey map[QuorumID]*G2Point
// AggSignature is the aggregated signature for all of the operators that signed the message for each quorum, mirroring the
// SignersAggPubKey.
Expand Down
4 changes: 3 additions & 1 deletion disperser/batcher/batcher.go
Original file line number Diff line number Diff line change
Expand Up @@ -596,7 +596,9 @@ func (b *Batcher) getBatchID(ctx context.Context, txReceipt *types.Receipt) (uin
return batchID, nil
}

// numBlobsAttestedByQuorum returns the number of blobs that have been successfully attested by the given quorums
// numBlobsAttestedByQuorum returns two values:
// 1. the number of blobs that have been successfully attested by all quorums
// 2. map[QuorumID]int mapping a quorum to the number of blobs that have been successfully attested by the quorum
func numBlobsAttestedByQuorum(signedQuorums map[core.QuorumID]*core.QuorumResult, headers []*core.BlobHeader) (int, map[core.QuorumID]int) {
numPassed := 0
quorumCounts := make(map[core.QuorumID]int)
Expand Down

0 comments on commit 3056bcc

Please sign in to comment.