PHPStan fixes.

LastDragon-ru · Jul 13, 2024 · ff8650a · ff8650a
1 parent 16686b9
commit ff8650a
Show file tree

Hide file tree

Showing 6 changed files with 16 additions and 21 deletions.
diff --git a/packages/eloquent/src/Testing/Package/Models/TestObject.php b/packages/eloquent/src/Testing/Package/Models/TestObject.php
@@ -2,7 +2,6 @@
 
 namespace LastDragon_ru\LaraASP\Eloquent\Testing\Package\Models;
 
-use Illuminate\Database\Eloquent\Factories\Factory;
 use Illuminate\Database\Eloquent\Factories\HasFactory;
 use Illuminate\Database\Eloquent\Model;
 use LastDragon_ru\LaraASP\Eloquent\Concerns\WithoutTimestamps;
@@ -11,6 +10,9 @@
  * @internal
  */
 class TestObject extends Model {
+    /**
+     * @use HasFactory<TestObjectFactory>
+     */
     use HasFactory;
     use WithoutTimestamps;
 
@@ -20,10 +22,7 @@ class TestObject extends Model {
      */
     protected $table = 'test_objects';
 
-    /**
-     * @return Factory<self>
-     */
-    protected static function newFactory(): Factory {
+    protected static function newFactory(): TestObjectFactory {
         return TestObjectFactory::new();
     }
 }
diff --git a/packages/graphql/src/Stream/Directives/Directive.php b/packages/graphql/src/Stream/Directives/Directive.php
@@ -638,7 +638,7 @@ public function getResolverClass(ResolverProvider $provider, FieldValue $value,
     }
 
     /**
-     * @return Closure(mixed, array<string, mixed>, GraphQLContext, ResolveInfo): EloquentBuilder<EloquentModel>
+     * @return Closure(mixed,array<string,mixed>,GraphQLContext,ResolveInfo):EloquentBuilder<covariant EloquentModel>
      */
     protected function getResolverModel(string $model): Closure {
         $class    = $this->namespaceModelClass($model);

diff --git a/packages/graphql/src/Stream/Directives/OffsetTest.php b/packages/graphql/src/Stream/Directives/OffsetTest.php
@@ -65,7 +65,7 @@ public static function dataProviderGetFieldArgumentValue(): array {
     // <editor-fold desc="Helpers">
     // =========================================================================
     /**
-     * @param array<int, string|int> $path
+     * @param list<string|int> $path
      */
     private static function getResolveInfo(array $path): ResolveInfo {
         $info       = Mockery::mock(ResolveInfo::class);

diff --git a/packages/graphql/src/Testing/Package/Data/Models/TestObject.php b/packages/graphql/src/Testing/Package/Data/Models/TestObject.php
@@ -2,7 +2,6 @@
 
 namespace LastDragon_ru\LaraASP\GraphQL\Testing\Package\Data\Models;
 
-use Illuminate\Database\Eloquent\Factories\Factory;
 use Illuminate\Database\Eloquent\Factories\HasFactory;
 use Illuminate\Database\Eloquent\Model;
 use LastDragon_ru\LaraASP\Eloquent\Concerns\WithoutTimestamps;
@@ -14,6 +13,9 @@
  * @property string $value
  */
 class TestObject extends Model {
+    /**
+     * @use HasFactory<TestObjectFactory>
+     */
     use HasFactory;
     use WithoutTimestamps;
 
@@ -35,10 +37,7 @@ class TestObject extends Model {
      */
     public $incrementing = false;
 
-    /**
-     * @return Factory<self>
-     */
-    protected static function newFactory(): Factory {
+    protected static function newFactory(): TestObjectFactory {
         return TestObjectFactory::new();
     }
 }
diff --git a/packages/graphql/src/Testing/Package/Data/Models/TestObjectSearchable.php b/packages/graphql/src/Testing/Package/Data/Models/TestObjectSearchable.php
@@ -2,7 +2,6 @@
 
 namespace LastDragon_ru\LaraASP\GraphQL\Testing\Package\Data\Models;
 
-use Illuminate\Database\Eloquent\Factories\Factory;
 use Illuminate\Database\Eloquent\Factories\HasFactory;
 use Illuminate\Database\Eloquent\Model;
 use Laravel\Scout\Searchable;
@@ -15,8 +14,11 @@
  * @property string $value
  */
 class TestObjectSearchable extends Model {
-    use Searchable;
+    /**
+     * @use HasFactory<TestObjectSearchableFactory>
+     */
     use HasFactory;
+    use Searchable;
     use WithoutTimestamps;
 
     /**
@@ -37,10 +39,7 @@ class TestObjectSearchable extends Model {
      */
     public $incrementing = false;
 
-    /**
-     * @return Factory<self>
-     */
-    protected static function newFactory(): Factory {
+    protected static function newFactory(): TestObjectSearchableFactory {
         return TestObjectSearchableFactory::new();
     }
 }
diff --git a/packages/migrator/src/Extenders/SmartMigrator.php b/packages/migrator/src/Extenders/SmartMigrator.php
@@ -27,10 +27,8 @@ public static function create(Migrator $migrator): self {
     // =========================================================================
     /**
      * @phpcsSuppress SlevomatCodingStandard.TypeHints.ParameterTypeHint.MissingNativeTypeHint
-     *
+     * @inheritDoc
      * @param array<array-key, mixed>|string $paths
-     *
-     * @return array<array-key, string>
      */
     #[Override]
     public function getMigrationFiles($paths): array {