refactor(graphql): Added default implementation of `InputObject::getO…

…perators()`.
LastDragon-ru · Jan 31, 2024 · 53f01f7 · 53f01f7
1 parent 467b023
commit 53f01f7
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 49 deletions.
diff --git a/packages/graphql/src/Builder/Types/InputObject.php b/packages/graphql/src/Builder/Types/InputObject.php
@@ -135,7 +135,12 @@ protected function getOperators(
         InputSource|ObjectSource|InterfaceSource $source,
         Context $context,
     ): array {
-        return [];
+        $type      = $this->getTypeForOperators();
+        $operators = $type
+            ? $manipulator->getTypeOperators($this->getScope(), $type, $context)
+            : [];
+
+        return $operators;
     }
 
     /**
@@ -434,6 +439,10 @@ protected function isFieldDirectiveAllowed(
             || $directive instanceof RenameDirective;
     }
 
+    protected function getTypeForOperators(): ?string {
+        return null;
+    }
+
     protected function getTypeForFieldOperator(): ?string {
         return null;
     }

diff --git a/packages/graphql/src/SearchBy/Types/Condition.php b/packages/graphql/src/SearchBy/Types/Condition.php
@@ -22,13 +22,8 @@
 use LastDragon_ru\LaraASP\GraphQL\SearchBy\Operators;
 use Override;
 
-use function array_merge;
-use function array_unique;
-use function array_values;
 use function is_string;
 
-use const SORT_REGULAR;
-
 class Condition extends InputObject {
     #[Override]
     public function getTypeName(TypeSource $source, Context $context): string {
@@ -53,24 +48,6 @@ protected function getDescription(
         return "Available conditions for `{$source}` (only one property allowed at a time).";
     }
 
-    /**
-     * @inheritDoc
-     */
-    #[Override]
-    protected function getOperators(
-        Manipulator $manipulator,
-        InputSource|ObjectSource|InterfaceSource $source,
-        Context $context,
-    ): array {
-        return array_values(array_unique(
-            array_merge(
-                parent::getOperators($manipulator, $source, $context),
-                $manipulator->getTypeOperators($this->getScope(), Operators::Extra, $context),
-            ),
-            SORT_REGULAR,
-        ));
-    }
-
     #[Override]
     protected function getFieldMarkerOperator(): string {
         return Operator::class;
@@ -81,6 +58,11 @@ protected function getFieldMarkerIgnored(): ?string {
         return Ignored::class;
     }
 
+    #[Override]
+    protected function getTypeForOperators(): ?string {
+        return Operators::Extra;
+    }
+
     #[Override]
     protected function getTypeForFieldOperator(): ?string {
         return Operators::Object;

diff --git a/packages/graphql/src/SortBy/Types/Clause.php b/packages/graphql/src/SortBy/Types/Clause.php
@@ -22,13 +22,8 @@
 use LastDragon_ru\LaraASP\GraphQL\SortBy\Operators;
 use Override;
 
-use function array_merge;
-use function array_unique;
-use function array_values;
 use function is_string;
 
-use const SORT_REGULAR;
-
 class Clause extends InputObject {
     #[Override]
     public function getTypeName(TypeSource $source, Context $context): string {
@@ -53,26 +48,6 @@ protected function getDescription(
         return "Sort clause for `{$source}` (only one property allowed at a time).";
     }
 
-    /**
-     * @inheritDoc
-     */
-    #[Override]
-    protected function getOperators(
-        Manipulator $manipulator,
-        InputSource|ObjectSource|InterfaceSource $source,
-        Context $context,
-    ): array {
-        return array_values(
-            array_unique(
-                array_merge(
-                    parent::getOperators($manipulator, $source, $context),
-                    $manipulator->getTypeOperators($this->getScope(), Operators::Extra, $context),
-                ),
-                SORT_REGULAR,
-            ),
-        );
-    }
-
     #[Override]
     protected function isFieldConvertableImplicit(
         Manipulator $manipulator,
@@ -103,6 +78,11 @@ protected function getFieldMarkerIgnored(): ?string {
         return Ignored::class;
     }
 
+    #[Override]
+    protected function getTypeForOperators(): ?string {
+        return Operators::Extra;
+    }
+
     #[Override]
     protected function getTypeForFieldOperator(): ?string {
         return Operators::Object;