fix(graphql-printer): Default value `Settings::isNormalizeArguments()…

…` set to `false` because the order of arguments may be important.
LastDragon-ru · Oct 18, 2023 · 5198e6e · 5198e6e
1 parent 5b9e5b2
commit 5198e6e
Show file tree

Hide file tree

Showing 22 changed files with 178 additions and 178 deletions.
diff --git a/packages/graphql-printer/src/PrinterTest~export-InputObjectTypeDefinition.graphql b/packages/graphql-printer/src/PrinterTest~export-InputObjectTypeDefinition.graphql
@@ -9,8 +9,8 @@ input InputUnused {
 Directive description
 """
 directive @directive(
-    hidden: InputHidden
     location: String
+    hidden: InputHidden
 )
 repeatable on
     | ARGUMENT_DEFINITION

diff --git a/packages/graphql-printer/src/PrinterTest~export-InterfaceType.graphql b/packages/graphql-printer/src/PrinterTest~export-InterfaceType.graphql
@@ -18,8 +18,8 @@
     Directive description
     """
     directive @directive(
-        hidden: InputHidden
         location: String
+        hidden: InputHidden
     )
     repeatable on
         | ARGUMENT_DEFINITION

diff --git a/packages/graphql-printer/src/PrinterTest~export-ObjectType.graphql b/packages/graphql-printer/src/PrinterTest~export-ObjectType.graphql
@@ -32,8 +32,8 @@ implements
 Directive description
 """
 directive @directive(
-    hidden: InputHidden
     location: String
+    hidden: InputHidden
 )
 repeatable on
     | ARGUMENT_DEFINITION

diff --git a/packages/graphql-printer/src/PrinterTest~export-UnionType.graphql b/packages/graphql-printer/src/PrinterTest~export-UnionType.graphql
@@ -5,8 +5,8 @@ union Union =
 Directive description
 """
 directive @directive(
-    hidden: InputHidden
     location: String
+    hidden: InputHidden
 )
 repeatable on
     | ARGUMENT_DEFINITION

diff --git a/packages/graphql-printer/src/PrinterTest~export-UnionTypeDefinitionNode.graphql b/packages/graphql-printer/src/PrinterTest~export-UnionTypeDefinitionNode.graphql
@@ -5,8 +5,8 @@
     Directive description
     """
     directive @directive(
-        hidden: InputHidden
         location: String
+        hidden: InputHidden
     )
     repeatable on
         | ARGUMENT_DEFINITION

diff --git a/packages/graphql-printer/src/PrinterTest~print-Schema-DefaultSettings.graphql b/packages/graphql-printer/src/PrinterTest~print-Schema-DefaultSettings.graphql
@@ -2,8 +2,8 @@
 Directive description
 """
 directive @directive(
-    hidden: InputHidden
     location: String
+    hidden: InputHidden
 )
 repeatable on
     | ARGUMENT_DEFINITION
@@ -139,12 +139,12 @@ scalar Scalar
 
 type Mutation {
     mutate(
-        a: InputA
-
         scalar: Int! = 123
         @directive(
             location: "argument"
         )
+
+        a: InputA
     ): [TypeB!]
 }
 
@@ -161,13 +161,13 @@ type Query {
     scalar: Scalar
 
     type(
-        a: InputA
-
         scalar: Int! = 123
         @directive(
-            hidden: null
             location: "argument"
+            hidden: null
         )
+
+        a: InputA
     ): TypeA!
 
     union: Union

diff --git a/...aphql-printer/src/PrinterTest~print-Schema-TestSettings-DirectiveDefinitionFilter.graphql b/...aphql-printer/src/PrinterTest~print-Schema-TestSettings-DirectiveDefinitionFilter.graphql
@@ -126,12 +126,12 @@ scalar Scalar
 
 type Mutation {
     mutate(
-        a: InputA
-
         scalar: Int! = 123
         @directive(
             location: "argument"
         )
+
+        a: InputA
     ): [TypeB!]
 }
 
@@ -148,13 +148,13 @@ type Query {
     scalar: Scalar
 
     type(
-        a: InputA
-
         scalar: Int! = 123
         @directive(
-            hidden: null
             location: "argument"
+            hidden: null
         )
+
+        a: InputA
     ): TypeA!
 
     union: Union

diff --git a/packages/graphql-printer/src/PrinterTest~print-Schema-TestSettings-Everything.graphql b/packages/graphql-printer/src/PrinterTest~print-Schema-TestSettings-Everything.graphql
@@ -17,8 +17,8 @@ on
 Directive description
 """
 directive @directive(
-    hidden: InputHidden
     location: String
+    hidden: InputHidden
 )
 repeatable on
     | ARGUMENT_DEFINITION
@@ -174,12 +174,12 @@ scalar String
 
 type Mutation {
     mutate(
-        a: InputA
-
         scalar: Int! = 123
         @directive(
             location: "argument"
         )
+
+        a: InputA
     ): [TypeB!]
 }
 
@@ -196,13 +196,13 @@ type Query {
     scalar: Scalar
 
     type(
-        a: InputA
-
         scalar: Int! = 123
         @directive(
-            hidden: null
             location: "argument"
+            hidden: null
         )
+
+        a: InputA
     ): TypeA!
 
     union: Union

diff --git a/...graphql-printer/src/PrinterTest~print-Schema-TestSettings-NoDirectivesDefinitions.graphql b/...graphql-printer/src/PrinterTest~print-Schema-TestSettings-NoDirectivesDefinitions.graphql
@@ -111,12 +111,12 @@ scalar Scalar
 
 type Mutation {
     mutate(
-        a: InputA
-
         scalar: Int! = 123
         @directive(
             location: "argument"
         )
+
+        a: InputA
     ): [TypeB!]
 }
 
@@ -133,13 +133,13 @@ type Query {
     scalar: Scalar
 
     type(
-        a: InputA
-
         scalar: Int! = 123
         @directive(
-            hidden: null
             location: "argument"
+            hidden: null
         )
+
+        a: InputA
     ): TypeA!
 
     union: Union

diff --git a/...es/graphql-printer/src/PrinterTest~print-Schema-TestSettings-TypeDefinitionFilter.graphql b/...es/graphql-printer/src/PrinterTest~print-Schema-TestSettings-TypeDefinitionFilter.graphql
@@ -2,8 +2,8 @@
 Directive description
 """
 directive @directive(
-    hidden: InputHidden
     location: String
+    hidden: InputHidden
 )
 repeatable on
     | ARGUMENT_DEFINITION
@@ -139,12 +139,12 @@ scalar Scalar
 
 type Mutation {
     mutate(
-        a: InputA
-
         scalar: Int! = 123
         @directive(
             location: "argument"
         )
+
+        a: InputA
     ): [TypeB!]
 }
 
@@ -161,13 +161,13 @@ type Query {
     scalar: Scalar
 
     type(
-        a: InputA
-
         scalar: Int! = 123
         @directive(
-            hidden: null
             location: "argument"
+            hidden: null
         )
+
+        a: InputA
     ): TypeA!
 
     union: Union

diff --git a/packages/graphql-printer/src/PrinterTest~print-Schema-TestSettings-TypeFilter.graphql b/packages/graphql-printer/src/PrinterTest~print-Schema-TestSettings-TypeFilter.graphql
@@ -132,12 +132,12 @@ scalar Scalar
 
 type Mutation {
     mutate(
-        a: InputA
-
         scalar: Int! = 123
         @directive(
             location: "argument"
         )
+
+        a: InputA
     ): [TypeB!]
 }
 
@@ -149,12 +149,12 @@ type Query {
     scalar: Scalar
 
     type(
-        a: InputA
-
         scalar: Int! = 123
         @directive(
             location: "argument"
         )
+
+        a: InputA
     ): TypeA!
 
     union: Union

diff --git a/packages/graphql-printer/src/PrinterTest~print-Schema-TestSettings.graphql b/packages/graphql-printer/src/PrinterTest~print-Schema-TestSettings.graphql
@@ -2,8 +2,8 @@
 Directive description
 """
 directive @directive(
-    hidden: InputHidden
     location: String
+    hidden: InputHidden
 )
 repeatable on
     | ARGUMENT_DEFINITION
@@ -139,12 +139,12 @@ scalar Scalar
 
 type Mutation {
     mutate(
-        a: InputA
-
         scalar: Int! = 123
         @directive(
             location: "argument"
         )
+
+        a: InputA
     ): [TypeB!]
 }
 
@@ -161,13 +161,13 @@ type Query {
     scalar: Scalar
 
     type(
-        a: InputA
-
         scalar: Int! = 123
         @directive(
-            hidden: null
             location: "argument"
+            hidden: null
         )
+
+        a: InputA
     ): TypeA!
 
     union: Union

diff --git a/packages/graphql-printer/src/Settings/ImmutableSettings.php b/packages/graphql-printer/src/Settings/ImmutableSettings.php
@@ -21,7 +21,7 @@ abstract class ImmutableSettings implements Settings {
     protected bool             $normalizeEnums                    = true;
     protected bool             $normalizeInterfaces               = true;
     protected bool             $normalizeFields                   = true;
-    protected bool             $normalizeArguments                = true;
+    protected bool             $normalizeArguments                = false;
     protected bool             $normalizeDescription              = true;
     protected bool             $normalizeDirectiveLocations       = true;
     protected bool             $alwaysMultilineUnions             = true;

diff --git a/packages/graphql-printer/src/Testing/TestSettings.php b/packages/graphql-printer/src/Testing/TestSettings.php
@@ -21,7 +21,7 @@ class TestSettings extends ImmutableSettings {
     protected bool             $normalizeEnums                    = true;
     protected bool             $normalizeInterfaces               = true;
     protected bool             $normalizeFields                   = true;
-    protected bool             $normalizeArguments                = true;
+    protected bool             $normalizeArguments                = false;
     protected bool             $normalizeDescription              = true;
     protected bool             $normalizeDirectiveLocations       = true;
     protected bool             $alwaysMultilineUnions             = true;

diff --git a/packages/graphql/src/Printer/PrinterTest~print-Schema-DefaultSettings.graphql b/packages/graphql/src/Printer/PrinterTest~print-Schema-DefaultSettings.graphql
@@ -1,8 +1,8 @@
 directive @codeDirective(
-    custom: [CodeDirectiveScalarCustomClass]
     enum: CodeDirectiveEnum
     input: CodeDirectiveInput
     scalar: CodeDirectiveScalar!
+    custom: [CodeDirectiveScalarCustomClass]
 )
 repeatable on
     | INTERFACE
@@ -202,17 +202,17 @@ type Query {
 
     c(
         a: SchemaInput = {
-            a: "aaa"
-            b: A
-            c: "ccc"
-            d: A
             e: {
-                a: "aaa"
-                b: A
-                c: "ccc"
-                d: A
                 f: ["aaa", "bbb", "ccc", "ddd"]
+                d: A
+                c: "ccc"
+                b: A
+                a: "aaa"
             }
+            d: A
+            c: "ccc"
+            b: A
+            a: "aaa"
         }
     ): CodeScalar
     @mock

diff --git a/...aphql/src/Printer/PrinterTest~print-Schema-TestSettings-DirectiveDefinitionFilter.graphql b/...aphql/src/Printer/PrinterTest~print-Schema-TestSettings-DirectiveDefinitionFilter.graphql
@@ -150,17 +150,17 @@ type Query {
 
     c(
         a: SchemaInput = {
-            a: "aaa"
-            b: A
-            c: "ccc"
-            d: A
             e: {
-                a: "aaa"
-                b: A
-                c: "ccc"
-                d: A
                 f: ["aaa", "bbb", "ccc", "ddd"]
+                d: A
+                c: "ccc"
+                b: A
+                a: "aaa"
             }
+            d: A
+            c: "ccc"
+            b: A
+            a: "aaa"
         }
     ): CodeScalar
     @mock