Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use shorthand nullability typings for better readability #5733

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jnoordsij
Copy link
Contributor

WHY

BEFORE - What was wrong? What was happening before this PR?

When working on #5732, I encountered some other (nullable) types that could be simplified, to improve readability.

AFTER - What is happening after this PR?

Cleaner code.

HOW

How did you achieve that, in technical terms?

Use shorthand.

Is it a breaking change?

No (or not really); only the change in RegisterUploadEvents::handle is a change in behavior, due to no longer allowing null; however explicit null passing seems unlikely and unwanted here.

How can we test the before & after?

??

If the PR has changes in multiple repos please provide the command to checkout all branches, eg.:

git checkout "dev-branch-name" &&
cd vendor/backpack/crud && git checkout crud-branch-name &&
cd ../pro && git checkout pro-branch-name &&
cd ../../..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant