Use shorthand nullability typings for better readability #5733
+8
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY
BEFORE - What was wrong? What was happening before this PR?
When working on #5732, I encountered some other (nullable) types that could be simplified, to improve readability.
AFTER - What is happening after this PR?
Cleaner code.
HOW
How did you achieve that, in technical terms?
Use shorthand.
Is it a breaking change?
No (or not really); only the change in
RegisterUploadEvents::handle
is a change in behavior, due to no longer allowingnull
; however explicitnull
passing seems unlikely and unwanted here.How can we test the before & after?
??
If the PR has changes in multiple repos please provide the command to checkout all branches, eg.: