Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Laravel 9 support added. #85

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

carbonvader
Copy link

composer.json updated for Laravel 9 which will be released this month.

The patch can be tested/used by others by adding my repository to composer.json until it's released officially.

{
    "require": {
        "laravelium/feed": "dev-laravel-9-patch",
    }
}

"repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/carbonvader/eloquent-sluggable.git"
        }
]

@carbonvader carbonvader marked this pull request as ready for review January 19, 2022 16:36
@nguillaumin
Copy link

Thanks for this, I also need Laravel 9 compatibility.

I think your composer.json file points to the wrong repository though, shouldn't it be https://github.com/carbonvader/laravel-feed/ ? Also the branch name seems to be laravel-9-patch.

For the pull request, comparing with the Laravel v8 upgrade it seems a few more changes are required, see: f1ed914 . Especially changelog, readme and GitHub actions config. Maybe it has a better chance of being accepted with these additional changes.

"wiki": "https://github.com/Laravelium/laravel-feed/wiki"
},
"require": {
"php": ">=7.3",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Laravel 9 requires PHP 8.0.2 I think, so that may need to be bumped?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants