Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Sange & Yonin to better match retail #6442

Merged
merged 5 commits into from
Nov 20, 2024

Conversation

WinterSolstice8
Copy link
Member

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Fixes Yonin enmity value & decay to match retail
Fix Sange animation
Convert Sange to retail's Sange, including augments
Adds some TODOs for barrage enhancement
fixes a typo or two

Sange not giving +racc at 5/5 merits directly (therefore the +racc must be applied only to daken invisibly):
sange racc doesnt boost

Sange animation capture:
sange

Steps to test these changes

Use sange, use yonin, see them work correctly

With Sange, you'll need to breakpoint in the attacks to see the additional merits/augs work
To get a correct Koga Chainmail+2 do the following:
image

@zach2good zach2good merged commit d6ada2a into LandSandBoat:base Nov 20, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants