Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Adds missing region to Sanction effect #6414

Merged

Conversation

LoxleyXI
Copy link
Contributor

@LoxleyXI LoxleyXI commented Nov 7, 2024

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Sanction is missing a ToAU region, causing crystals to drop from mobs around Nyzul Isle Staging Point with Signet and not with Sanction.

Steps to test these changes

Mobs in Alzadaal Undersea Ruins should only drop crystals if the player has Sanction and not if the player has Signet

@zach2good zach2good merged commit ce2f580 into LandSandBoat:base Nov 8, 2024
13 checks passed
@LoxleyXI LoxleyXI deleted the core-sanction-region-alzadaal branch November 9, 2024 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants