Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lua] Fix Banishing Gate messaging, timing, and trigger areas #6413

Conversation

TracentEden2
Copy link
Contributor

@TracentEden2 TracentEden2 commented Nov 5, 2024

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

This PR fixes three issues with the Banishing Gates in GC.

  1. The PR changes the opening and closing messages for each gate to be zone wide (so seen by every player in the zone) as on retail.
  2. The PR changes the timing of the gates so the first gate is open for 30 seconds, second gate for 45 seconds, and third gate for 60 seconds as on retail.
  3. The PR fixes some small positioning errors with the trigger areas thus making pressing the levers easier and similar to retail.

The basic logic is from KnowOne (on Eden) and the logic was validated by him on retail. I adapted his code to work on LSB.

Draft still as might make one more small change from KnowOne

Steps to test these changes

Go to the Banishing Gates and open with one player while having another player in the zone. Notice the messages are zone wide and the timings vary for different gates.

@TracentEden2 TracentEden2 marked this pull request as draft November 5, 2024 22:04
@TracentEden TracentEden force-pushed the add_zone_wide_banishing_gate_messaging branch 2 times, most recently from 80fd694 to 73193d8 Compare November 6, 2024 11:56
@TracentEden2 TracentEden2 changed the title [Lua] Fix Banishing Gate messaging and timing [Lua] Fix Banishing Gate messaging, timing, and trigger areas Nov 6, 2024
@TracentEden2 TracentEden2 marked this pull request as ready for review November 6, 2024 12:17
@TracentEden TracentEden force-pushed the add_zone_wide_banishing_gate_messaging branch from 73193d8 to bf3798f Compare November 6, 2024 12:24
@zach2good zach2good merged commit 9b9bc7b into LandSandBoat:base Nov 7, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants