Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fix] San d'Oria Mission 5-1 #6411

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

slashtangent
Copy link
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Fixes a bug where the cutscene being played was for the quest "Father and Son" instead of the proper event related to 5-1

Steps to test these changes

Completed mission 4-1 and has not started mission 5-1 yet. Talk to Grilau : !pos -241.987 6.999 57.887 231

@slashtangent slashtangent changed the title [Bug Fix] Grilau Event ID [Bug Fix] San d'Oria Mission 5-1 Nov 5, 2024
@claywar
Copy link
Contributor

claywar commented Nov 5, 2024

Could you please post screenshots of these two different dialogues? Limited on time lately, but I believe I have notes somewhere from running through these missions after implementing.

@slashtangent
Copy link
Contributor Author

Could you please post screenshots of these two different dialogues? Limited on time lately, but I believe I have notes somewhere from running through these missions after implementing.

Event 52:
xiloader_4Gxy9TNYj1

Event 61 (Current Code) - Plays Cutscene from quest "Father and Son"
xiloader_VWU5Sg0y4l

Copy link
Contributor

@claywar claywar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks. Easy stamp in my book.

@zach2good zach2good merged commit ef8e120 into LandSandBoat:base Nov 7, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants