Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lua: Fixes condition for qm1 in the Stars of Ifrit quest #6408

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

LoxleyXI
Copy link
Contributor

@LoxleyXI LoxleyXI commented Nov 4, 2024

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

This NPC should appear between 18 and 6 on full moon. However, the condition is wrong, so that it never appears. This PR corrects the issue. https://www.bg-wiki.com/ffxi/The_Stars_of_Ifrit

Steps to test these changes

During full moon, the NPC will appear between 18 and 6.

Copy link
Contributor

@zach2good zach2good left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

@zach2good zach2good merged commit fe5d3ee into LandSandBoat:base Nov 4, 2024
13 checks passed
@LoxleyXI LoxleyXI deleted the lua-npc-airship-qm1-hour branch November 4, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants