Ceizak Battlegrounds NM, Mobskills, HP/MP/ItemLevel

[Yuchemey]

I affirm:

• I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
• I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
• I have read and understood the Contributing Guide and the Code of Conduct.
• I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

I have added the HP, MP, levels, magic spells, and skills for Taxet, Mastop, Unfettered Twitherym, Supernal Chapuli and Transcendent Scorpion. I have also created custom mob skills and scripted their behavior, including specific weaknesses to match as possible the behavior from retail.

Unfettered Twitherym, will obtain an Damage taken of -90% @ 74,49,24, the only way to remove it needs to use a skillchain of the affinity chosen.

Supernal Chapuli, will obtain a damage taken of -100% 2-3 sec inbetween mobskills,

Transcendent Scorpion, will heal debuff everytime it uses TP Move, it will use a skill list over 50% and another one under 50%

Mastop, everytime it uses booming bombination it reduce it's PDT and RDT until it reaches -100% also Booming Bombination has a 10% chance of gaining an aura of silence and amnesia.

Taxet, will starts his damage taken -99%, will increase everytime it uses exuviation to a maximum of 20. will focus on using exuviation until it reaches 50%. Under 50% taxet will use Benumbered Blaze

Steps to test these changes

Pop each NMs at their respective location.

Unfettered Twitherym - Celadon ygrete shard I - Ceizak Battlegrounds(J-7)
Supernal Chapuli - Celadon ygrete shard II - Ceizak Battlegrounds(J-9)
Transcendent Scorpion - Celadon ygrete shard III - Ceizak Battlegrounds(I-10)
Mastop - Celadon ygrete shard IV - Ceizak Battlegrounds(G-8)
Taxet - Celadon ygrete shard V - Ceizak Battlegrounds(G-10)

[zach2good]

Lots going well here 👍

I've left a lot of comments, but this is going mainly in the right direction.
Main themes are:

• Double check skills you've marked as AoE, knockback, etc.
• Extract out strings and magic numbers into tables/enums etc.
• Generally check formatting

[zach2good]

Looks like I got my magic/mob_skill aoe flags mixed up in my brain, but double check just to be sure:

enum AOE_TYPE
{
    NONE      = 0,
    ROUND     = 1, // Normal AoE type
    CONE      = 4, // Forward conal AoE
    REAR_CONE = 8, // conal AoE behind the source
};

[WinterSolstice8]

where'd you get this list from?

[jmcmorris]

Do you have retail captures that this is all based off of? Including those would be great. I recently did the Erosion Dust and Exuviation mobskills and am curious where you're getting these differences from. Are they truly different? If so then are they different mobskill IDs? Happy to see effort on the content front though!

[claywar]

So I pulled down your branch to check, and Virelai is a false-positive from CI. The other 6 errors you have need to be corrected though. mobMagicalMove only returns integer, so no "info" and you also have a physical parameter being used (numhitslanded) where that function does not accept it.

[Yuchemey]

I have fixed most of it. But i am still having trouble with the change of the magic numbers in mobs/ (nms).lua

[Yuchemey]

Do you have retail captures that this is all based off of? Including those would be great. I recently did the Erosion Dust and Exuviation mobskills and am curious where you're getting these differences from. Are they truly different? If so then are they different mobskill IDs? Happy to see effort on the content front though!

I was wrong by a few but not off. so i went to fight a wamoura in mount zhayolms and capture it's data.
This is the data: https://gist.github.com/Yuchemey/12e674c8132d3210dfd32c43e23e4f30

so how the mob works is. when it's HP is High or at max. it recovers about .0012% of it's maxHP
when reaches 0-1% it will heal it self for 0.05% of it maxHP per Debuffs.

if you are asking. where i am getting mob:getMaxHP(), i just took a guess and for some reason: it just works.

[Yuchemey]

I will start all over 1 NM at a time.
my server is not up to date with all the changes it has been made since june/july 2024

[WinterSolstice8]

I will start all over 1 NM at a time. my server is not up to date with all the changes it has been made since june/july 2024

Yes I think that's a good idea, I've been keeping this PR in the back of my mind but there's too much scope here to really sit down and review it all at once

[Yuchemey]

Thanks for the feed back, i will close this PR and make 1 NM at a time.