Rework AST #3
Merged
Rework AST #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KubEF
reviewed
Apr 16, 2024
| ) | ||
|
|
||
| -- | Function name, must be lowercase | ||
| newtype Fun = FunName {funName :: Text} |
There was a problem hiding this comment.
А почему не type Fun = Text ? Просто тут как будто избыточность какая-то возникает
There was a problem hiding this comment.
У нас вырисовываются три раздельных пространства имён: функции, переменные и конструкторы. Разделение на три точно разных типа выглядит очень даже оправданно в данном случае
gsvgit
reviewed
Apr 16, 2024
| Con Con [Expr] | ||
| | -- | Lambda abstraction | ||
| Lam Var Expr | ||
| | -- | Function call |
There was a problem hiding this comment.
А можно для дебилов: чем вызов функции от применения отличется?
There was a problem hiding this comment.
Как я понимаю, узел Fun просто висит слева в аппликации и хранит в себе имя функции. Всё. Вероятно так удобнее для дистилляции :)
@KubEF, поправь, пожалуйста, если я не прав
For some reason it's broken with --amend and now deprecated
KubEF
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.