Filter y test #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Freihart512
reviewed
Dec 6, 2023
movies-app/src/App.module.css
Outdated
| text-align: center; | ||
| font-size: 3rem; | ||
| text-shadow: 1px 1px 2px pink; | ||
| } */ |
There was a problem hiding this comment.
debes dejar en todo los archivos una linea al final sin espacios
Comment on lines
+34
to
+39
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
Comment on lines
8
to
9
| onChange(genre); | ||
| navigate(`?genre=${(genre)}`); |
There was a problem hiding this comment.
te invitaria a replantear esta parte es decir es una contradiccion navegar y actulaizar un estado
ya que si navegas se repinta toda la pagina por lo que setear el estado pierde el sentido
tu componente padre deberia reaccionar al cambio en la url
| width: 90%; | ||
| height: auto; | ||
| } | ||
| } |
There was a problem hiding this comment.
mismo caso que arriba linea sin espacio al final
| import { GenreFilter } from "./FilterGenre"; | ||
| import OrderFilter from "./OrderApi"; | ||
|
|
||
| // export function MoviesGrid() { |
Comment on lines
202
to
218
| const fetchData = () => { | ||
| console.log("Current Page:", currentPage); | ||
| console.log("Total Pages:", totalPages); | ||
| const apiUrl = search | ||
| ? `/search/movie?query=${search}` | ||
| : `/discover/movie?with_genres=${selectedGenre}&include_adult=false&include_video=false&language=en-US&page=${currentPage}&sort_by=${sortBy}`; | ||
|
|
||
| get(apiUrl) | ||
| .then((data) => { | ||
| console.log("API Response:", data); | ||
| setMovies(data.results); | ||
| setTotalPages(data.total_pages); | ||
| }) | ||
| .catch((error) => { | ||
| console.error("Error fetching data:", error); | ||
| }); | ||
| }; |
There was a problem hiding this comment.
la funcion se debe declarar antes de usarla es decir sube este codigo arriba de la linea 193
Comment on lines
+12
to
+15
| get("/movie/" + movieId).then(data => { | ||
| setMovie(data) | ||
|
|
||
| }) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.