Query Datasets #6182
Query Datasets #6182
Conversation
| @@ -62,4 +63,10 @@ public Set<String> getReservedPropertyNames(Domain domain, User user) | |||
|
|
|||
| return Collections.unmodifiableSet(fields); | |||
| } | |||
|
|
|||
| @Override | |||
| public boolean isProvisioned(Container container, String name) | |||
There was a problem hiding this comment.
Hmm, this is interesting. The ContinuousDomainKind is provisioned, but query dataset does not have a domain do do domainkind... Hmm. Maybe make this static and add a comment? or change calling code to ask the dataset, not the domainkind? (I haven't look to see where this is called yet.)
There was a problem hiding this comment.
I moved this to the abstract DatasetDomainKind class. It does ultimately ask the dataset if it's a query dataset or not. It's called outside the study module so it doesn't really have any idea what kind of domain it is at that point, it's up to the domain kind to figure out if it's provisioned. I added a comment.
| { | ||
| if (property.equals(QueryProperty.Name)) | ||
| { | ||
| for (QueryPropertyChange change : changes) |
| User user = _userSchema.getUser(); | ||
| if (!user.hasRootAdminPermission() && !hasPermission(user, ReadPermission.class)) | ||
| return null; | ||
| return new QueryDatasetUpdateService(this); |
There was a problem hiding this comment.
I think you can just return null here.
There was a problem hiding this comment.
Ah yes, that is more concise. Done.
Rationale
Live query snapshot datasets. Essentially an unprovisioned dataset backed by a live query.
Changes