Customizable File Templates for Sources, Sample Types & Assay Designs #6167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnathe
requested changes
Dec 26, 2024
|
|
||
| public String getDomainFileDirectory() | ||
| { | ||
| return getKindName(); |
There was a problem hiding this comment.
do we want toLowerCase() for these? maybe it doesn't matter but the other dir names seem to all be lowercase.
experiment/src/org/labkey/experiment/controllers/property/PropertyController.java
Outdated
Show resolved
Hide resolved
experiment/src/org/labkey/experiment/controllers/property/PropertyController.java
Outdated
Show resolved
Hide resolved
experiment/src/org/labkey/experiment/controllers/property/PropertyController.java
Outdated
Show resolved
Hide resolved
experiment/src/org/labkey/experiment/controllers/property/PropertyController.java
Outdated
Show resolved
Hide resolved
experiment/src/org/labkey/experiment/controllers/property/PropertyController.java
Outdated
Show resolved
Hide resolved
experiment/src/org/labkey/experiment/controllers/property/PropertyController.java
Outdated
Show resolved
Hide resolved
| if (!template_.second.toLowerCase().contains("exportexceltemplate")) | ||
| existingCustomTemplates.add(template_); | ||
| } | ||
| if (!updatedTemplates.equals(existingCustomTemplates)) |
There was a problem hiding this comment.
since these vars are both ArrayLists, will they ever be considered equal? From the UI, I opened the manage templates modal for a sample type that already had 2 custom tempaltes > edited the label for one and then put the label back to what it was > clicked Save. The code still went into this if statement.
There was a problem hiding this comment.
Hmm.. for this scenario described, it doesn't go inside the if block for me.
experiment/src/org/labkey/experiment/controllers/property/PropertyController.java
Outdated
Show resolved
Hide resolved
cnathe
approved these changes
Dec 30, 2024
Comment on lines
8368
to
8370
| QueryDef queryDef = null; | ||
| if (queryDef == null) | ||
| queryDef = QueryManager.get().getQueryDef(container, schemaName, queryName, false); |
There was a problem hiding this comment.
queryDef is always null here so not sure that if statement is needed.
Suggested change
| QueryDef queryDef = null; | |
| if (queryDef == null) | |
| queryDef = QueryManager.get().getQueryDef(container, schemaName, queryName, false); | |
| QueryDef queryDef = QueryManager.get().getQueryDef(container, schemaName, queryName, false); | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Custom import templates were previously supported by overriding the the datatype's query metadata xml by providing the webdav location of an uploaded file. This set of PRs allows users to manage custom templates from app UI.
Related Pull Requests
Changes
UpdateDomainImportTemplateActionapi to upload custom template files and save domain template settings to query xml at query.querydef.metadatagetQueryDetailsActionto includeavailablestatus of import templatesCustomImportTemplatesproduct feature