Improved corruption resilient behavior

LTRData · May 24, 2024 · a238a20 · a238a20
1 parent d2afda5
commit a238a20
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 7 deletions.
diff --git a/Library/DiscUtils.Ntfs/NtfsFileSystem.cs b/Library/DiscUtils.Ntfs/NtfsFileSystem.cs
@@ -132,9 +132,21 @@ public NtfsFileSystem(Stream stream)
         if (VolumeInfo.Version >= VolumeInformation.VersionW2k)
         {
             _context.SecurityDescriptors = new SecurityDescriptors(GetFile(MasterFileTable.SecureIndex));
-            _context.ObjectIds = new ObjectIds(GetFile(GetDirectoryEntry(@"$Extend\$ObjId").Value.Reference));
-            _context.ReparsePoints = new ReparsePoints(GetFile(GetDirectoryEntry(@"$Extend\$Reparse").Value.Reference));
-            _context.Quotas = new Quotas(GetFile(GetDirectoryEntry(@"$Extend\$Quota").Value.Reference));
+
+            if (GetDirectoryEntry(@"$Extend\$ObjId") is { } objIdFile)
+            {
+                _context.ObjectIds = new ObjectIds(GetFile(objIdFile.Reference));
+            }
+
+            if (GetDirectoryEntry(@"$Extend\$Reparse") is { } reparse)
+            {
+                _context.ReparsePoints = new ReparsePoints(GetFile(reparse.Reference));
+            }
+
+            if (GetDirectoryEntry(@"$Extend\$Quota") is { } quota)
+            {
+                _context.Quotas = new Quotas(GetFile(quota.Reference));
+            }
         }
 
 #if false

diff --git a/Library/DiscUtils.Ntfs/StructuredNtfsAttribute.cs b/Library/DiscUtils.Ntfs/StructuredNtfsAttribute.cs
@@ -24,6 +24,7 @@
 using System.Buffers;
 using System.IO;
 using DiscUtils.Streams;
+using LTRData.Extensions.Formatting;
 
 namespace DiscUtils.Ntfs;
 
@@ -96,11 +97,18 @@ public override string ToString()
 
     public override void Dump(TextWriter writer, string indent)
     {
-        Initialize();
-        writer.WriteLine($"{indent}{AttributeTypeName} ATTRIBUTE ({(Name == null ? "No Name" : Name)})");
-        _structure.Dump(writer, $"{indent}  ");
+        try
+        {
+            Initialize();
+            writer.WriteLine($"{indent}{AttributeTypeName} ATTRIBUTE ({Name ?? "No Name"})");
+            _structure.Dump(writer, $"{indent}  ");
 
-        _primaryRecord.Dump(writer, $"{indent}  ");
+            _primaryRecord.Dump(writer, $"{indent}  ");
+        }
+        catch (Exception ex)
+        {
+            writer.WriteLine($"{indent}{AttributeTypeName} ATTRIBUTE: {ex.JoinMessages()}");
+        }
     }
 
     private void Initialize()