Fixed some FAT exceptions

* Fixed NullReferenceException when parameter object was not supplied to file system class. * Fixed dictionary exception for FAT with volume name entry, when volume name matched a file name in root directory.
LTRData · Oct 16, 2024 · 36607b7 · 36607b7
1 parent 27fc757
commit 36607b7
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/Library/DiscUtils.Fat/Directory.cs b/Library/DiscUtils.Fat/Directory.cs
@@ -420,9 +420,13 @@ internal void UpdateEntry(long id, DirectoryEntry entry)
     private void AddEntryRaw(long pos, DirectoryEntry entry)
     {
         _entries.Add(pos, entry);
+
         // Update the short and full name lookup tables
-        _shortFileNameToEntry.Add(entry.Name.ShortName, pos);
-        _fullFileNameToEntry.Add(entry.Name.FullName, pos);
+        if (!entry.Attributes.HasFlag(FatAttributes.VolumeId))
+        {
+            _shortFileNameToEntry.Add(entry.Name.ShortName, pos);
+            _fullFileNameToEntry.Add(entry.Name.FullName, pos);
+        }
     }
 
     private void LoadEntries()

diff --git a/Library/DiscUtils.Fat/FatFileSystemOptions.cs b/Library/DiscUtils.Fat/FatFileSystemOptions.cs
@@ -39,7 +39,7 @@ internal FatFileSystemOptions()
 
     internal FatFileSystemOptions(FileSystemParameters parameters)
     {
-        if (parameters.FileNameEncoding is not null)
+        if (parameters?.FileNameEncoding is not null)
         {
             FileNameEncoding = parameters.FileNameEncoding;
         }