Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for pixel ranges and composable geometries. #151

Merged
merged 32 commits into from
Jan 25, 2024
Merged

Add support for pixel ranges and composable geometries. #151

merged 32 commits into from
Jan 25, 2024

Conversation

erykoff
Copy link
Collaborator

@erykoff erykoff commented Jan 20, 2024

This completely refactors the packed boolean arrays to be more efficient, and to work with arbitrary slices. This enables setting of giant pixel ranges (large area masks) with minimal memory overhead.

erykoff added 29 commits November 15, 2023 15:21
@erykoff
Try to fix the readthedocs configuration.
57a6135
@erykoff
Add initial support for pixel range geometry.
de730db
@erykoff
Fix flake8 problems.
d5e7adc
@erykoff
Fix compression name for RICE.
3d47a3a
@erykoff
Fix numpy deprecation warning on -1 conversion.
9481c5c
@erykoff
Add and/or to operations allowed on bit_packed maps.
568503a
@erykoff
First refactoring of unified range setting.
cb6eb96
@erykoff
Create internal function to make update_values_pix a lot clearer.
dfaee20
@erykoff
Add and/or/add operations to pixel range updates.
6fa3aff
@erykoff
Add tests for pixel range setting.
fb37063
@erykoff
Use better packbits for wide masks.
17bdc22
@erykoff
Refactor _PackedBoolArray for more efficient slicing.
1ffd885 
This is the first part of the refactor.
@erykoff
Add more working functionality.
1e1d04b
@erykoff
Simplify initialization code.
3af7807
@erykoff
Remove unused old code.
be0f526
@erykoff
Fix usage with empty index arrays.
85c6feb
@erykoff
Update tests for _PackedBoolArray for new refactored code.
7a9e4a8
@erykoff
Add checks for empty indices when setting.
a9d34d6
@erykoff
Simplify geometry realization code.
2a80f5f
@erykoff
Add ability to combine geometric objects directly with maps.
939061a
@erykoff
Add tests for new map + geom combinations.
7434f0b
@erykoff
Rename test for future expansions.
6acce73
@erykoff
Update docstrings.
18e03eb
@erykoff
Remove unnecessary sentinel from test.
79d54d8
@erykoff
Update documentation for composable geometries.
729e099
@erykoff
Fix installation instructions.
e7c2b92
@erykoff
Put lower bound on hpgeom requirement.
46f195a
@erykoff
Update build system.
58fd9b5
@erykoff
Update workflows.
435ff00
@beckermr beckermr self-assigned this Jan 21, 2024
beckermr
beckermr requested changes Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments. Congrats on the test suite. It was painful to read and no doubt it was painful to write!

tests/test_pixel_ranges.py Show resolved Hide resolved
healsparse/packedBoolArray.py Show resolved Hide resolved
healsparse/packedBoolArray.py Show resolved Hide resolved
healsparse/packedBoolArray.py Outdated Show resolved Hide resolved
healsparse/packedBoolArray.py Show resolved Hide resolved
healsparse/packedBoolArray.py Outdated Show resolved Hide resolved
tests/test_packedboolarray.py Show resolved Hide resolved
tests/test_packedboolarray.py Show resolved Hide resolved
@erykoff erykoff merged commit 17457af into main Jan 25, 2024
6 checks passed
@erykoff erykoff deleted the pixel_ranges branch January 25, 2024 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beckermr beckermr beckermr approved these changes

Assignees

@beckermr beckermr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erykoff @beckermr