Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image simulation bug fix #290

Merged

Conversation

nkhadka21
Copy link
Collaborator

This PR fixes a minor bug in image simulation for multi-source lensing and adds an appropriate test function to cover this case.

@nkhadka21 nkhadka21 merged commit 58f2395 into LSST-strong-lensing:main Nov 26, 2024
3 checks passed
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.84%. Comparing base (2c8243f) to head (8ac4905).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #290      +/-   ##
==========================================
+ Coverage   97.80%   97.84%   +0.04%     
==========================================
  Files          74       74              
  Lines        5000     5001       +1     
==========================================
+ Hits         4890     4893       +3     
+ Misses        110      108       -2     
Files with missing lines Coverage Δ
slsim/lens.py 96.89% <100.00%> (+0.29%) ⬆️

... and 2 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants