Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve "Remove extra paragraph spacing" feature #1203

Merged
merged 47 commits into from
Dec 29, 2024

Conversation

Palloxin
Copy link
Contributor

@Palloxin Palloxin commented Aug 11, 2024

repost of #1164 due to conflicts (related code moved to another file)
Currently, it just removes all <br>.
With this change you could:
-remove excessive <br>
-remove some zero-width spaces and &nbsp; (I found a novel that put them in a p to simulate an extra empty paragraph).
-remove a br after the end of a p. It's just extra space.
-remove a br present right before the end of a p.

EDIT: the feature code has regex chaining now.

@nyagami
Copy link
Member

nyagami commented Aug 12, 2024

<br> <p class="haha">
failed this test

android/app/src/main/assets/js/core.js Outdated Show resolved Hide resolved
android/app/src/main/assets/js/core.js Outdated Show resolved Hide resolved
android/app/src/main/assets/js/core.js Outdated Show resolved Hide resolved
@Palloxin
Copy link
Contributor Author

Palloxin commented Sep 4, 2024

Double br exception:

@Palloxin

This comment was marked as outdated.

@rajarsheechatterjee rajarsheechatterjee merged commit 2291591 into LNReader:master Dec 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants