Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage rework + fixes #746

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from
Draft

Conversation

Krakenied
Copy link
Collaborator

@Krakenied Krakenied commented Nov 16, 2024

TODO:

  • test storage rework (mysql)
  • test storage rework (yaml)
  • create copy for invalid yaml files on save
  • docs
  • fix isCancelled() on 1.8
[14:22:48 WARN]: [Quests] Task #1272 for Quests v3.15.2-3185f28 generated an exception
java.lang.NoSuchMethodError: org.bukkit.scheduler.BukkitTask.isCancelled()Z
        at com.leonardobishop.quests.bukkit.scheduler.bukkit.BukkitWrappedTask.isCancelled(BukkitWrappedTask.java:25) ~[?:?]
        at com.leonardobishop.quests.bukkit.runnable.QuestsAutoSaveRunnable.forceSave(QuestsAutoSaveRunnable.java:82) ~[?:?]
        at com.leonardobishop.quests.bukkit.runnable.QuestsAutoSaveRunnable.run(QuestsAutoSaveRunnable.java:36) ~[?:?]
        at org.bukkit.craftbukkit.v1_8_R3.scheduler.CraftTask.run(CraftTask.java:59) ~[server.jar:git-iSpigot-PaperEdition]
        at org.bukkit.craftbukkit.v1_8_R3.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:410) ~[server.jar:git-iSpigot-PaperEdition]
        at net.minecraft.server.v1_8_R3.MinecraftServer.B(MinecraftServer.java:1038) ~[server.jar:git-iSpigot-PaperEdition]
        at net.minecraft.server.v1_8_R3.DedicatedServer.B(DedicatedServer.java:523) ~[server.jar:git-iSpigot-PaperEdition]
        at net.minecraft.server.v1_8_R3.MinecraftServer.A(MinecraftServer.java:948) ~[server.jar:git-iSpigot-PaperEdition]
        at net.minecraft.server.v1_8_R3.MinecraftServer.run(MinecraftServer.java:835) ~[server.jar:git-iSpigot-PaperEdition]
        at java.lang.Thread.run(Thread.java:750) ~[?:1.8.0_422]

TODO to be moved to another PR:

  • storing preferences - tracked quest id
  • menu rework
  • placeholders support in menus (for example cancel gui)
  • make hidden option hide the quest from more menus
  • count instead of bool Number of times you’ve completed quests  #739 + yaml migrator

@Krakenied Krakenied changed the title Storage rework Storage & menu rework Nov 16, 2024
@Krakenied Krakenied changed the title Storage & menu rework Storage rework + fixes Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant