Fix not deleted bossbar when stop the server again

[Elikill58]

It's nice you made changes for async, but with this you re-create a new bug with bossbar that are not disappearing when restarting the sevrer.

Actually, bossbar created and not deleted could not be removed by owner as they are not showed in /bossbar remove command.

[Krakenied]

Make sure your server fork and your plugins dont break boss bar behavior, im unable to reproduce the issue

[Krakenied]

(unused boss bars are automatically collected by GC)

[Krakenied]

(so there is a memory leak on your server which is definitely not a sensible reason to put more unnecessary code to the plugin lol)

[Krakenied]

tbh it's also possible that there are old boss bars present on your server which were created using the keyed method

[Krakenied]

also, your fix will most likely cause CME because keyed boss bars are stored server side in a HashMap

[Elikill58]

And not keyed bossbar are not saved ? Also, with this fix, the server that report me this bug no longer have issue.
They are using purpur

[Krakenied]

And not keyed bossbar are not saved ? Also, with this fix, the server that report me this bug no longer have issue. They are using purpur

Simple boss bars aren't saved at all:

Keyed boss bars are:

As you can see, there is no logic to store the simple boss bars (they are basically collected by garbage collector), whereas the keyed ones are stored in a hash map and are even saved in the world files, making it necessary to remove them manually.

[Elikill58]

Oh ok. And did you check if the /save-all command for example save them manually ? Like if there is another system that save them ?

[Krakenied]

As you can see, CustomBossEvents is empty after running the /save-all command

2023-11-07.00-46-48.mp4

[Elikill58]

Oh ok, thanks for all of this informations, and sorry for disturbing