-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix not deleted bossbar #550
Conversation
That's exactly the reason I said you shouldn't be using keyed bossbars for such a feature... It's also bad in terms of performance. |
Where did you said that? Also, what could the other way? Without key but with bukkit bossbar they will be saved too. Else, with Adventure they will not but it's a paper-only feature |
Without key the bossbars shouldnt be saved |
Oh yes, I just checked javadoc and you're right. |
Could you rebase your branch to resolve the merge conflict? I would do it for you but I do not want to modify the master branch in your repository |
I just discard commit and make it again for cleaner commit :) But why you don't like tabs? |
Thanks, the rest of the project uses spaces so I do not want to end up with mixed indentation |
Just for consistency. A tab could be a different number of columns depending on your environment, but a space is always one column. |
If you have the bossbar when the server goes down, you will keep the bossbar forever as it's saved in world.
With this PR, it's fixed.
(Thanks Hamta for reporting this issue)