Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix not deleted bossbar #550

Merged
merged 2 commits into from
Sep 18, 2023
Merged

Fix not deleted bossbar #550

merged 2 commits into from
Sep 18, 2023

Conversation

Elikill58
Copy link
Contributor

If you have the bossbar when the server goes down, you will keep the bossbar forever as it's saved in world.

With this PR, it's fixed.

(Thanks Hamta for reporting this issue)

@Krakenied
Copy link
Collaborator

Krakenied commented Sep 11, 2023

That's exactly the reason I said you shouldn't be using keyed bossbars for such a feature... It's also bad in terms of performance.

@Elikill58
Copy link
Contributor Author

That's exactly the reason I said you shouldn't be using keyed bossbars for such a feature... It's also bad in terms of performance.

Where did you said that? Also, what could the other way? Without key but with bukkit bossbar they will be saved too. Else, with Adventure they will not but it's a paper-only feature

@Krakenied
Copy link
Collaborator

Without key the bossbars shouldnt be saved

@Elikill58
Copy link
Contributor Author

Without key the bossbars shouldnt be saved

Oh yes, I just checked javadoc and you're right.
I used key for simplicity to get the bossbar, but as you said we can use without key but we should save all bossbar by ourself

@LMBishop
Copy link
Owner

Could you rebase your branch to resolve the merge conflict? I would do it for you but I do not want to modify the master branch in your repository

@Elikill58 Elikill58 closed this Sep 18, 2023
@Elikill58 Elikill58 reopened this Sep 18, 2023
@Elikill58
Copy link
Contributor Author

Elikill58 commented Sep 18, 2023

I just discard commit and make it again for cleaner commit :) But why you don't like tabs?

@LMBishop LMBishop merged commit a101ba1 into LMBishop:master Sep 18, 2023
2 checks passed
@LMBishop
Copy link
Owner

I just discord commit and make it again for cleaner commit :) But why you don't like tabs?

Thanks, the rest of the project uses spaces so I do not want to end up with mixed indentation

@Krakenied
Copy link
Collaborator

Krakenied commented Sep 18, 2023

I just discord commit and make it again for cleaner commit :) But why you don't like tabs?

Just for consistency. A tab could be a different number of columns depending on your environment, but a space is always one column.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants