Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: Don't clobber un-namespaced options #600

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

ZedThree
Copy link

@ZedThree ZedThree commented Nov 6, 2024

Fixes #538

Non-SUNDIALS namespaced variables may be used by other projects so don't unset them

  • Please target the develop branch not main.
  • Review our Contributing Guide, and ensure that you sign your last commit (at minimum) as per the guide.
  • Provide a concise description of what your pull request does, and why it is needed/benefical.
  • Add a note about your change to the CHANGELOG.md and docs/shared/RecentChanges.rst files. Notice that the former is a markdown file and the latter is reStructuredText, so the formatting is slightly different.
  • After your PR is opened, ensure that all of the tests are passing (a SUNDIALS developer will have to allow the testing to run).

Fixes LLNL#538

Non-`SUNDIALS` namespaced variables may be used by other
projects so don't `unset` them

Signed-off-by: Peter Hill <[email protected]>
Copy link
Member

@balos1 balos1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. This will make the CMake GUI display options that are irrelevant unless the right ENABLE_* variable is set, but we will have to find a different way to address that.

@balos1 balos1 added this to the SUNDIALS Next milestone Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants