Bugfix/windows fortran builds

.github/workflows/windows-latest-mingw.yml

@@ -71,6 +71,8 @@ jobs:
       # Execute tests
       run: ctest --output-on-failure
 
+    # TODO(CJB): shared libraries with the fortran interfaces turned on
+    # fail to link correctly with this toolchain see https://github.com/LLNL/sundials/issues/507.
     - name: Configure CMake (Shared)
       # Configure CMake in a 'build' subdirectory
       run: |
@@ -79,7 +81,7 @@ jobs:
           -B ${GITHUB_WORKSPACE}/build_shared \
           -DCMAKE_BUILD_TYPE=${{env.BUILD_TYPE}} \
           -DCMAKE_C_FLAGS=-Wno-deprecated-declarations \
-          -DBUILD_FORTRAN_MODULE_INTERFACE=ON \
+          -DBUILD_FORTRAN_MODULE_INTERFACE=OFF \
           -DBUILD_STATIC_LIBS=OFF \
           -DSUNDIALS_BUILD_WITH_PROFILING=ON \
           -DSUNDIALS_LOGGING_LEVEL=2 \

doc/shared/RecentChanges.rst

@@ -116,6 +116,8 @@ Fix bug on LLP64 platforms (like Windows 64-bit) where ``KLU_INDEXTYPE`` could b
 Check if size of ``SuiteSparse_long`` is 8 if the size of ``sunindextype`` is 8
 when using KLU.
 
+Fixed several build errors with the Fortran interfaces on Windows systems.
+
 **Deprecation Notices**
 
 Numerous ARKODE stepper-specific functions are now deprecated in favor of
@@ -129,5 +131,3 @@ The unsupported implementations of ``N_VGetArrayPointer`` and
 ``N_VSetArrayPointer`` for the *hypre* and PETSc vectors are now deprecated.
 Users should access the underlying wrapped external library vector objects
 instead with ``N_VGetVector_ParHyp`` and ``N_VGetVector_Petsc``, respectively.
-
-Fixed several build errors with the Fortran interfaces on Windows systems.

doc/shared/sundials/Fortran.rst

@@ -557,8 +557,7 @@ Important notes on portability
 ------------------------------
 
 The SUNDIALS Fortran 2003 interface *should* be compatible with any compiler
-supporting the Fortran 2003 ISO standard. However, it has only been tested and
-confirmed to be working with GNU Fortran 4.9+ and Intel Fortran 18.0.1+.
+supporting the Fortran 2003 ISO standard.
 
 Upon compilation of SUNDIALS, Fortran module (``.mod``) files are generated for
 each Fortran 2003 interface. These files are highly compiler specific, and thus

doc/shared/sundials/Install.rst

@@ -590,6 +590,11 @@ illustration only.
 
    Default: ``OFF``
 
+   .. warning:: There is a known issue with MSYS/gfortran and SUNDIALS shared libraries
+      that causes linking the Fortran interfaces to fail when buidling SUNDIALS. For
+      now the work around is to only build with static libraries when using MSYS with
+      gfortran on Windows.
+
 .. cmakeoption:: SUNDIALS_LOGGING_LEVEL
 
    Set the maximum logging level for the SUNLogger runtime API. The higher this is set,

examples/kinsol/F2003_serial/kinLaplace_bnd_f2003.f90

@@ -131,7 +131,7 @@ program main
   ! local variables
   real(c_double)  :: fnormtol, fnorm(1)
   integer(c_int)  :: ierr
-  integer(c_int) :: mset, msubset
+  integer(c_long) :: mset, msubset
 
   type(c_ptr)                    :: sunctx        ! sundials context
   type(N_Vector),        pointer :: sunvec_u      ! sundials vectors

src/sunadaptcontroller/imexgus/fmod_int32/CMakeLists.txt

@@ -17,10 +17,8 @@ sundials_add_f2003_library(sundials_fsunadaptcontrollerimexgus_mod
     fsunadaptcontroller_imexgus_mod.f90 fsunadaptcontroller_imexgus_mod.c
   LINK_LIBRARIES
     PUBLIC sundials_fcore_mod
-  OBJECT_LIBRARIES
   OUTPUT_NAME
     sundials_fsunadaptcontrollerimexgus_mod
-  OBJECT_LIB_ONLY
 )
 
 message(STATUS "Added SUNAdaptController_ImExGus F2003 interface")

src/sunadaptcontroller/imexgus/fmod_int64/CMakeLists.txt

@@ -17,10 +17,8 @@ sundials_add_f2003_library(sundials_fsunadaptcontrollerimexgus_mod
     fsunadaptcontroller_imexgus_mod.f90 fsunadaptcontroller_imexgus_mod.c
   LINK_LIBRARIES
     PUBLIC sundials_fcore_mod
-  OBJECT_LIBRARIES
   OUTPUT_NAME
     sundials_fsunadaptcontrollerimexgus_mod
-  OBJECT_LIB_ONLY
 )
 
 message(STATUS "Added SUNAdaptController_ImExGus F2003 interface")

src/sunadaptcontroller/soderlind/fmod_int32/CMakeLists.txt

@@ -17,10 +17,8 @@ sundials_add_f2003_library(sundials_fsunadaptcontrollersoderlind_mod
     fsunadaptcontroller_soderlind_mod.f90 fsunadaptcontroller_soderlind_mod.c
   LINK_LIBRARIES
     PUBLIC sundials_fcore_mod
-  OBJECT_LIBRARIES
   OUTPUT_NAME
     sundials_fsunadaptcontrollersoderlind_mod
-  OBJECT_LIB_ONLY
 )
 
 message(STATUS "Added SUNAdaptController_Soderlind F2003 interface")