Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More CosmoFlow Fixes #2461

Merged
merged 4 commits into from
Jul 25, 2024
Merged

More CosmoFlow Fixes #2461

merged 4 commits into from
Jul 25, 2024

Conversation

fiedorowicz1
Copy link
Contributor

@fiedorowicz1 fiedorowicz1 commented Jul 2, 2024 •
edited
Loading

  • Fixes a bug in mini-batch counting for DistConv response shuffling.
  • Fixes hangs due to Hydrogen updates.
  • Adds cosine learning rate scheduler to CosmoFlow args.

@fiedorowicz1 fiedorowicz1 marked this pull request as ready for review July 22, 2024 16:29
ndryden
ndryden approved these changes Jul 22, 2024
View reviewed changes
Copy link
Collaborator

@ndryden ndryden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me once CI passes. (I triggered a rerun.)

@fiedorowicz1 fiedorowicz1 merged commit 7d69781 into LLNL:develop Jul 25, 2024
1 check passed
@fiedorowicz1 fiedorowicz1 deleted the fix-fix-cosmoflow branch July 25, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndryden ndryden ndryden approved these changes

@tbennun tbennun Awaiting requested review from tbennun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fiedorowicz1 @ndryden