Extensible configuration of the superbuild location #2426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bvanessen
force-pushed
the
bugfix_relocatable_superbuild
branch
from
9c535bd
to
75ac038
Compare
bvanessen
force-pushed
the
bugfix_relocatable_superbuild
branch
from
d3285b5
to
91b0054
Compare
location of the external superbuild dependencies easily relocatable.
…sted prefix path. Fixed bug where the forwarded CMAKE_PREFIX_PATH was overwritten when a package dependend on other packages.
…uperbuilt external libraries.
same setup file as the CI runs. Fixed the build issues for CI on corona. Removed scripts for building DHA and LBANN manually (outside of CI).
Improved the core dependencies for Power.
Co-authored-by: Tom Benson <[email protected]>
…ries via PIP in the stable dependencies.
Co-authored-by: Tom Benson <[email protected]>
…ring configuration.
time, the Lua module file will now activate it when loaded. Removed the TCL module file since it wasn't being used by systems. Added a prompt name to the python venv. Fixed an empty variable field in the Lassen gitlab code that deleted other variables.
deactivate an active environment before loading the LBANN module.
benson31
approved these changes
Aug 30, 2024
Comment on lines
+146
to
+147
| file(WRITE "${CMAKE_INSTALL_PREFIX}/logs/lbann_sb_suggested_cmake_prefix_path.sh" | ||
| "export CMAKE_PREFIX_PATH=${LBANN_SB_SUGG_CMAKE_PREFIX_PATH}\n") |
There was a problem hiding this comment.
Why do we need a second copy?
Comment on lines
+160
to
+163
| file(APPEND "${CMAKE_INSTALL_PREFIX}/logs/lbann_sb_suggested_cmake_prefix_path.sh" | ||
| "export AWS_OFI_RCCL_LIBDIR=${LBANN_SB_AWS_OFI_RCCL_PREFIX}/lib\n") | ||
| file(APPEND "${CMAKE_INSTALL_PREFIX}/logs/lbann_sb_suggested_cmake_prefix_path.sh" | ||
| "export LD_LIBRARY_PATH=${LBANN_SB_AWS_OFI_RCCL_PREFIX}/lib:\$\{LD_LIBRARY_PATH\}\n") |
There was a problem hiding this comment.
Why do we need a second copy?
There was a problem hiding this comment.
In multiple places we write out to a version of the file in two different locations. Primarily because I don't know how to write one file and then copy it.
There was a problem hiding this comment.
I guess what I was asking was "why do we need 2 copies?"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding some flexibility in the customized_build_env script to make the
location of the external superbuild dependencies easily relocatable.