Append -dirty to Git hashcode when working tree is dirty #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joshessman-llnl wrote:
The change here is small enough that it seems like we should probably check the git version and use the appropriate command. |
kennyweiss
requested changes
Jan 4, 2021
There was a problem hiding this comment.
Seems like a nice change @joshessman-llnl, but since we're not requiring a specific version of git and this is a known issue that is easy to workaround, it seems to me that we should check the git version and use the appropriate command.
OTOH, if others feel that we do not need to support older git versions, then we should document the minimum supported version somewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces
rev-parsewithdescribe, which was introduced in Git 2.4.12 (May 2017). Do we need to support versions of Git older than that?