Interface-independent wrapping #77
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #77 +/- ##
==========================================
+ Coverage 82.42% 83.1% +0.67%
==========================================
Files 10 11 +1
Lines 1064 1160 +96
==========================================
+ Hits 877 964 +87
- Misses 187 196 +9
Continue to review full report at Codecov.
|
|
Added ppc64le support and tests, but still need documentation on new interfaces |
mplegendre
changed the title
|
This should be ready for review |
|
Cool. It'll probably be a couple of weeks before I can really give it a look, but thanks for putting it together |
|
@mplegendre , last I looked I thought I had approved this? Oops. I'll approve it in a review now |
DavidPoliakoff
approved these changes
Oct 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An initial implementation of interface-independent wrapping, for feedback purposes. Use the new gotcha_sigfree_wrap() to wrap with pre/post wrappers that are independent of a function's signature, as discussed in #55.
Before merging this needs debugging prints, more tests, ppc64 support, and documentation.
This will also be complimented with a new gotcha query interface for listing libraries/symbols, which will allow one to do operations like wrap all functions exported from an arbitrary library.