added neutronics tools #23
Conversation
There was a problem hiding this comment.
Thanks @SteSeg for taking care of the neutronics part!
-
The CI is failing here because it's missing the
h5pypackage. It is also missingopenmcas a dependency. Could you add it to the requirements?Line 18 in eef7af6
-
Moreover you will have to add it to the ci workflow file?
-
Also the _version.py file should not be tracked. Did you do
git add .? 😈 -
Can we add a test to check that this function works?
| # angular and energy distribution | ||
|
|
||
| from pathlib import Path | ||
| from collections.abc import Iterable |
There was a problem hiding this comment.
Probably not important but do you know if there's a difference between this and
from typing import List| # angle column names | ||
| angles = df.columns[1:] | ||
| # angular bins in [0, pi) | ||
| pbins = np.cos([np.deg2rad(float(a)) for a in angles] + [np.pi]) |
There was a problem hiding this comment.
pretty sure there's a way to use angles directly without iterating through it and converting it to a float. pandas builds upon numpy
Co-authored-by: Rémi Delaporte-Mathurin <[email protected]>
Co-authored-by: Rémi Delaporte-Mathurin <[email protected]>
Co-authored-by: Rémi Delaporte-Mathurin <[email protected]>
Co-authored-by: Rémi Delaporte-Mathurin <[email protected]>
Co-authored-by: Rémi Delaporte-Mathurin <[email protected]>
Co-authored-by: Rémi Delaporte-Mathurin <[email protected]>
Added the neutronics folder in the package with the neutron generator characteristics and a function to generate it as openmc source.