Always on top feature #829
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LGUG2Z
force-pushed
the
master
branch
2 times, most recently
from
0c842e4 to
05af7ce
Compare
|
I finished all the work I have to do so this is a PR to enable the feature to have a window always on top so when you change the workspace the always-on-top window will move with the focus workspace. This is helpful if you have multiple monitors and are focusing on a specific workspace but also want to move a window. This feature will shorten the command you have to run to achieve this. There are also different scenarios in which this command can also be handy like moving multiple windows at once. This is my first PR so if something is wrong or you want me to change something or give me criticism PLEASE DO. I hope this PR can be helpful for somebody |
This commit ensures that the "send" behaviour is respected in named-workspace command variants such as send-to-named-workspace.
LGUG2Z
force-pushed
the
master
branch
2 times, most recently
from
fb92ba4 to
692da90
Compare
This reverts commit d0f9bc3.
This commit adds an optional --komorebi-config flag to the check command to allow users to check a komorebi.json file in an arbitrary location.
This commit adds support for specifying a layout flip axis for each workspace in the static configuration file.
This commit adds mutex lock scoping in WindowManager::enforce_workspace_rule to avoid a deadlock when should_update_focused_workspace evaluates to true. fix LGUG2Z#1212
If a user triggers the workspace reconciliator by clicking on an app in the start bar or via alt-tab, a notification should be sent to subscribers such as komorebi-bar so that the focused workspace can be updated. The various komorebi reconciliators and manager modules don't emit events to subscribers themselves (yet?), so for now we can pass on the uncloak event. Maybe we can look into expanding the Notification enum in the future. fix LGUG2Z#1211
This commit adds a new komorebic command "stackbar-mode" to allow users to change stackbar modes programmatically.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I create a feature which allows a window to be always on the focused workspace. So you only need to focus the workspace I have some things still to do:
-Clean up
-Window Manager Event on Destroy and Unmanaged
a more detailed description is coming when I got everything done but I wanted to make the pull request now because I promise it in the discord chat.