Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SLIP10 #1

Merged
merged 13 commits into from
Dec 15, 2023
Merged

Implement SLIP10 #1

merged 13 commits into from
Dec 15, 2023

Conversation

survived
Copy link
Contributor

@survived survived commented Dec 14, 2023

Implemented the library according to the specs

@survived survived requested a review from maurges December 14, 2023 15:47
@maurges
Copy link
Contributor

maurges commented Dec 14, 2023

Might have to change the name, slip10 already exists: https://docs.rs/slip10/

@survived
Copy link
Contributor Author

Oh I didn't check it. We'll need to come up with another name

Copy link
Contributor

@maurges maurges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the maths look right to me

src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
@maurges
Copy link
Contributor

maurges commented Dec 15, 2023

cargo test --lib --tests from workflow runs zero tests

@survived
Copy link
Contributor Author

cargo test --lib --tests from workflow runs zero tests

Fixed

@maurges
Copy link
Contributor

maurges commented Dec 15, 2023

What is the error?

Doctests fail to build without --all-features. Nothing major turns out.

src/errors.rs Show resolved Hide resolved
tests/test_vectors.rs Outdated Show resolved Hide resolved
@survived survived requested a review from maurges December 15, 2023 15:12
@survived survived merged commit 6c6e5bf into m Dec 15, 2023
7 checks passed
@survived survived deleted the version-0 branch December 15, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants