Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cggmp24 development #123

Draft
wants to merge 5 commits into
base: m
Choose a base branch
from
Draft

cggmp24 development #123

wants to merge 5 commits into from

Conversation

survived
Copy link
Contributor

@survived survived commented Dec 11, 2024

This is the branch in which we will work on updating implementation to the latest revision of CGGMP paper.

Note that cggmp24/m is protected branch, as well as m it requires a PR for any modification.

Upgrade plan:

  1. Merge paillier-zk repo into the cggmp repo
  2. Develop new ZK proofs needed for cggmp24
  3. Update the cggmp implementation
  4. Write migration guidelines
  5. Rename repo into cggmp24
  6. Release new library under cggmp24 name
  7. Legacy cggmp21 will get its own cggmp21/m protected branch reserved for security patches

This is the branch in which we will work on updating implementation to
the latest revision of CGGMP paper

Signed-off-by: Denis Varlakov <[email protected]>
@survived
Copy link
Contributor Author

@maurges does the plan looks okay?

This comment was marked as off-topic.

This comment was marked as off-topic.

@maurges
Copy link
Contributor

maurges commented Dec 11, 2024

Sounds reasonable. We can even do the moving of zk-proofs here before starting to work on cggmp24.

I'm not sure we want to rename just the repo. I think the old repo name should stay in some form (didn't we have enough problems with branches disappearing, imagine a whole repo). Maybe we could rename the repo and make a fork under the old name, and immediately archive it

@survived
Copy link
Contributor Author

I don't anticipate any problems, as github will be redirecting old urls, so even if we have git dependencies (I don't think we do), they will get resolved with new url automatically

@survived survived changed the title cggmp24 development start cggmp24 development Dec 11, 2024
@maurges
Copy link
Contributor

maurges commented Dec 12, 2024

github will be redirecting old urls

It's not guaranteed it will do, it even says so when you rename a repo

@survived
Copy link
Contributor Author

It's not guaranteed it will do, it even says so when you rename a repo

But it does it, e.g. https://github.com/LFDT-Lockness/slip-10 still redirects to the new repo.

The new release is going to be a breaking change, so it's okay even if git deps get broken

Signed-off-by: Denis Varlakov <[email protected]>
@maurges
Copy link
Contributor

maurges commented Dec 13, 2024

It does redirect, but it's not guaranteed that it will do and do it forever

The new release is going to be a breaking change, so it's okay even if git deps get broken

That's why I'm saying we should put an old version on the old URL

@survived
Copy link
Contributor Author

The new release is going to be a breaking change, so it's okay even if git deps get broken

That's why I'm saying we should put an old version on the old URL

I see. Yes it would be nice, but I want the repo name to reflect the crate name, and I don't want to keep the old one just to keep projects who use cggmp21 as git dependency intact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants