refactoring

LDAPAccountManager · Oct 29, 2023 · fda88da · fda88da
1 parent e43b7f5
commit fda88da
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/lam/templates/misc/ajax.php b/lam/templates/misc/ajax.php
@@ -406,17 +406,13 @@ private function manageWebauthnOwnDevices(): void {
 	private function dnSelection(): string {
 		$dn = trim($_POST['dn']);
 		if (empty($dn) || !get_preg($dn, 'dn')) {
-			$dnList = $this->getDefaultDns();
 			return '';
 		}
 		else {
 			$dnList = $this->getSubDns($dn);
 		}
 		$html = $this->buildDnSelectionHtml($dnList, $dn);
 		$json = json_encode(['dialogData' => $html], JSON_THROW_ON_ERROR);
-		if ($json === false) {
-			return '';
-		}
 		return $json;
 	}
 

diff --git a/phpstan.neon b/phpstan.neon
@@ -34,6 +34,6 @@ parameters:
 		- '#Parameter \#1 \$array of function array_keys expects array, mixed given.#'
 		- '#Argument of an invalid type mixed supplied for foreach, only iterables are supported.#'
 		- '#Parameter \#2 \$args of function call_user_func_array expects array<int\|string, mixed>, mixed given.#'
-		- '#Parameter \#1 \$input of method LAM\\AJAX\\Ajax::managePasswordChange\(\) expects array, mixed given.#'
+		- '#Parameter \#1 \$input of static method LAM\\AJAX\\Ajax::managePasswordChange\(\) expects array, mixed given.#'
 		- '#Parameter \#1 \$input of method LAM\\AJAX\\Ajax::checkPasswordStrength\(\) expects array, mixed given.#'
 		- '#Cannot access offset non-falsy-string on array<int\|string, string>\|object.#'