Skip to content

Commit

Permalink
Merge pull request #369 from LDAPAccountManager/feature/339_rejection…
Browse files Browse the repository at this point in the history
…_reason

Feature/339 rejection reason
  • Loading branch information
gruberroland authored Oct 4, 2024
2 parents 2c468d7 + 51b8dc0 commit 4bc6dd8
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 1 deletion.
2 changes: 2 additions & 0 deletions lam/HISTORY
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
December 2024 9.0
- Group of (unique) names, organisational roles: added member/owner count to PDF fields
- Usability improvements (350)
- LAM Pro:
-> Request access: added comment field for owners/approvers (339)
- Fixed bugs:
-> Windows: show more than 1000 LDAP entries when paged results is activated in server profile

Expand Down
8 changes: 7 additions & 1 deletion lam/docs/manual-sources/chapter-selfService.xml
Original file line number Diff line number Diff line change
Expand Up @@ -1937,6 +1937,9 @@
optional notes. This is available for the mails to the group
owners/managers.</para>

<para>Use $$request_comment$$ to inject the owner's or approver's
comment. This can be used in mails to approvers and requesters.</para>

<para>The wildcards $$approveLink$$ and $$rejectLink$$ resolve to an URL
that allows to approve/deny all requests listed in $$requested_groups$$.
This is available for the mails to the group owners/managers and
Expand Down Expand Up @@ -1975,6 +1978,8 @@

$$requested_groups$$

Comment: $$request_comment$$

Approve all: $$approveLink$$
Deny all: $$rejectLink$$

Expand All @@ -1989,8 +1994,9 @@
email:</emphasis><literallayout>
Dear $$cn$$,

your access request was approved.
your access request was approved/denied.
Requested groups: $$requested_groups$$
Comment: $$request_comment$$

Best regards,
IT team
Expand Down
6 changes: 6 additions & 0 deletions lam/lib/persistence.inc
Original file line number Diff line number Diff line change
Expand Up @@ -405,6 +405,9 @@ class ConfigDataImporter {
if (isset($value['historicRequests'])) {
$mainStep->addSubStep(new ImporterStep(_('Request history'), 'requestAccess_historicRequests', $value['historicRequests']));
}
if (isset($value['expirations'])) {
$mainStep->addSubStep(new ImporterStep(_('Revocation information'), 'requestAccess_expirations', $value['expirations']));
}
$steps[] = $mainStep;
}
break;
Expand Down Expand Up @@ -752,6 +755,9 @@ class ConfigDataImporter {
case 'historicRequests':
$database->importRequestHistory($data);
break;
case 'expirations':
$database->importExpirations($data);
break;
}
}
}
Expand Down

0 comments on commit 4bc6dd8

Please sign in to comment.