-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First-Tier contribution analysis tab #1046
Draft
marc-vdm
wants to merge
36
commits into
LCA-ActivityBrowser:main
Choose a base branch
from
marc-vdm:first_level_cont
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
…ty-browser into first_level_cont � Conflicts: � activity_browser/layouts/tabs/LCA_results_tabs.py
# Conflicts: # activity_browser/controllers/database.py # activity_browser/layouts/tabs/LCA_results_tabs.py
marc-vdm
changed the title
New Product (first-level) contribution analysis tab
First-Tier contribution analysis tab
Apr 20, 2024
7 tasks
# Conflicts: # activity_browser/controllers/database.py # activity_browser/layouts/tabs/LCA_results_tabs.py
# Conflicts: # activity_browser/layouts/tabs/LCA_results_tabs.py
Add: - CA data: use actual total instead of sum(abs) - CA data: make distinction between positive and negative rest values (LCA-ActivityBrowser#886) - CA data: sort based on average of row instead of first column (LCA-ActivityBrowser#887) - CA table: consistent dropping of empty (rest) rows (LCA-ActivityBrowser#1044) - CA figure: add marker to show total score when both positive and negative results present (LCA-ActivityBrowser#647)
…howing on negative totals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mrvisscher This PR is ready for testing by other people, based on more testing I hope we can remove some potential bugs and merge this.
New feature to implement contribution analysis for products.
Add:
rest
row sometimes doesn't show in table + index missing #1044)Example project:
positive_negative_CA.tar.gz
Example:
Checklist
bug
,feature
,ui
,change
,documentation
,breaking
,ci
as they show up in the changelog