Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent LBP3 reviews from showing up in LBP2 #1015

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

Slendy
Copy link
Contributor

@Slendy Slendy commented Apr 24, 2024

There is currently a bug where if you review an LBP3 level and load your profile in LBP2 the game freaks out because the level data won't be returned because of the GameVersionFilter. This PR adds similar filtering so that reviews from higher game versions are no longer returned. This change adds an extra SQL join to the review query.

new example generated query:

.param set @__targetUserId_0 1
.param set @__token_GameVersion_1 1

SELECT "r"."ReviewId", "r"."Deleted", "r"."DeletedBy", "r"."LabelCollection", "r"."ReviewerId", "r"."SlotId", "r"."Text", "r"."Thumb", "r"."ThumbsDown", "r"."ThumbsUp", "r"."Timestamp"
FROM "Reviews" AS "r"
INNER JOIN "Slots" AS "s" ON "r"."SlotId" = "s"."SlotId"
WHERE "r"."ReviewerId" = @__targetUserId_0 AND "s"."GameVersion" <= @__token_GameVersion_1
ORDER BY "r"."Timestamp" DESC

@Slendy Slendy requested review from Zaprit and sudokoko April 24, 2024 18:44
Copy link
Member

@sudokoko sudokoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks fine

Copy link
Member

@Zaprit Zaprit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idk, kinda looks like code to me
tenor-ezgif com-added-text(1)

@Slendy Slendy added this pull request to the merge queue Apr 29, 2024
Merged via the queue into LBPUnion:main with commit ed5bb5d Apr 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants