Prevent duplicate profile pins

ProjectLighthouse.Servers.GameServer/Controllers/UserController.cs

@@ -180,7 +180,7 @@ public async Task<IActionResult> UpdateMyPins()
         // Sometimes the update gets called periodically as pin progress updates via playing,
         // may not affect equipped profile pins however, so check before setting it.
         string currentPins = user.Pins;
-        string newPins = string.Join(",", pinJson.ProfilePins);
+        string newPins = string.Join(",", pinJson.ProfilePins.Distinct());
 
         if (string.Equals(currentPins, newPins)) return this.Ok("[{\"StatusCode\":200}]");
 

ProjectLighthouse.Tests.GameApiTests/Unit/Controllers/UserControllerTests.cs

@@ -177,4 +177,29 @@ public async Task UpdateMyPins_ShouldNotSave_WhenPinsAreEqual()
         Assert.Equal(expectedPins, dbMock.Users.First().Pins);
         Assert.Equal(expectedResponse, pinsResponse);
     }
+
+    [Fact]
+    public async Task UpdateMyPins_ShouldRemove_DuplicatePins()
+    {
+        UserEntity entity = MockHelper.GetUnitTestUser();
+        entity.Pins = "1234";
+        List<UserEntity> users = new()
+        {
+            entity,
+        };
+        await using DatabaseContext dbMock = await MockHelper.GetTestDatabase(users);
+
+        UserController userController = new(dbMock);
+        userController.SetupTestController("{\"profile_pins\": [1234, 1234]}");
+
+        const string expectedPins = "1234";
+        const string expectedResponse = "[{\"StatusCode\":200}]";
+
+        IActionResult result = await userController.UpdateMyPins();
+
+        string pinsResponse = result.CastTo<OkObjectResult, string>();
+
+        Assert.Equal(expectedPins, dbMock.Users.First().Pins);
+        Assert.Equal(expectedResponse, pinsResponse);
+    }
 }