Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking(window.py): api changed #45

Merged
merged 5 commits into from
Oct 24, 2023
Merged

breaking(window.py): api changed #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
be449f7
breaking(window.py): remove add*layer; add create_glazing_system
Oct 24, 2023
da33376
update test to use pyenergyplus dataset for reference models
Oct 24, 2023
4873165
update test to make windows happy
Oct 24, 2023
5097a81
update tests
Oct 24, 2023
e735e39
update tests
Oct 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 7 additions & 15 deletions frads/eplus.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,17 +70,13 @@ def add_glazing_system(self, glzsys: GlazingSystem):
>>> model = load_energyplus_model(Path("model.idf"))
>>> model.add_glazing_system(glazing_system1)
"""
if glzsys.solar_results is None or glzsys.photopic_results is None:
glzsys.compute_solar_photopic_results()
if glzsys.solar_results is None or glzsys.photopic_results is None:
raise ValueError("Solar and photopic results not computed.")

name = glzsys.name
gap_inputs = []
for i, gap in enumerate(glzsys.gaps):
gap_inputs.append(
epmodel.ConstructionComplexFenestrationStateGapInput(
gas=getattr(epm.GasType, gap[0][0].name.lower()), thickness=gap[-1]
gas=gap.gas[0].gas.capitalize(), thickness=gap.thickness
)
)
layer_inputs: List[epmodel.ConstructionComplexFenestrationStateLayerInput] = []
Expand All @@ -94,21 +90,17 @@ def add_glazing_system(self, glzsys: GlazingSystem):
emissivity_front=layer.emissivity_front,
emissivity_back=layer.emissivity_back,
infrared_transmittance=layer.ir_transmittance,
directional_absorptance_front=glzsys.solar_results.layer_results[
i
].front.absorptance.angular_total,
directional_absorptance_back=glzsys.solar_results.layer_results[
i
].back.absorptance.angular_total,
directional_absorptance_front=glzsys.solar_front_absorptance[i],
directional_absorptance_back=glzsys.solar_back_absorptance[i],
)
)
input = epmodel.ConstructionComplexFenestrationStateInput(
gaps=gap_inputs,
layers=layer_inputs,
solar_reflectance_back=glzsys.solar_results.system_results.back.reflectance.matrix,
solar_transmittance_back=glzsys.solar_results.system_results.front.transmittance.matrix,
visible_transmittance_back=glzsys.photopic_results.system_results.back.transmittance.matrix,
visible_transmittance_front=glzsys.photopic_results.system_results.front.transmittance.matrix,
solar_reflectance_back=glzsys.solar_back_reflectance,
solar_transmittance_back=glzsys.solar_back_transmittance,
visible_transmittance_back=glzsys.visible_back_reflectance,
visible_transmittance_front=glzsys.visible_front_transmittance,
)
self.add_construction_complex_fenestration_state(name, input)

Expand Down
Loading