Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed hit printing #13

Merged
merged 3 commits into from
Jan 31, 2017
Merged

changed hit printing #13

merged 3 commits into from
Jan 31, 2017

Conversation

yetkinyilmaz
Copy link
Contributor

denote the particle barcode for all hits instead of only for first hit
and “?” for others.

before:

100000720,10000050,[566.19733899495418, 824.26972121692847]
100000520, ?,[1004.8522372399623, 1729.2402902181764]
100000230, ?,[1304.9914538841922, 2701.2954864822213]
100000080, ?,[1455.0021635262074, 3725.9856017078287]
100000950, ?,[1442.1755673331181, 4787.4972201545352]
100000410, ?,[1252.1010433407478, 5867.8993666613787]
100000460, ?,[867.75234154604095, 6946.0064694572065]
100000070, ?,[267.98619794832985, 7995.5102024642056]

after:
100000390,10000020,[-894.22687954837522, -447.61399429997255]
100000250,10000020,[-1850.7827589599983, -758.02584331698006]
100000290,10000020,[-2854.7188327693616, -922.26915042840665]
100000750,10000020,[-3890.1799170026334, -930.85993218603517]
100000650,10000020,[-4939.8196377253798, -773.42223057182923]
100000180,10000020,[-5983.9773128737861, -438.19575421473837]
100000630,10000020,[-6999.4379253225452, 88.705859763765602]
100000570,10000020,[-7957.397825154123, 824.51188725962993]

denote the particle barcode for all hits instead of only for first hit
and “?” for others.

before:

100000720,10000050,[566.19733899495418, 824.26972121692847]
100000520, ?,[1004.8522372399623, 1729.2402902181764]
100000230, ?,[1304.9914538841922, 2701.2954864822213]
100000080, ?,[1455.0021635262074, 3725.9856017078287]
100000950, ?,[1442.1755673331181, 4787.4972201545352]
100000410, ?,[1252.1010433407478, 5867.8993666613787]
100000460, ?,[867.75234154604095, 6946.0064694572065]
100000070, ?,[267.98619794832985, 7995.5102024642056]

after:
100000390,10000020,[-894.22687954837522, -447.61399429997255]
100000250,10000020,[-1850.7827589599983, -758.02584331698006]
100000290,10000020,[-2854.7188327693616, -922.26915042840665]
100000750,10000020,[-3890.1799170026334, -930.85993218603517]
100000650,10000020,[-4939.8196377253798, -773.42223057182923]
100000180,10000020,[-5983.9773128737861, -438.19575421473837]
100000630,10000020,[-6999.4379253225452, 88.705859763765602]
100000570,10000020,[-7957.397825154123, 824.51188725962993]
@@ -45,6 +45,5 @@ def plotHit(self):

def printHit(self, dataset = False):
""" print hit to stdout """
if dataset and self.detpos != 0 and self.detpos != 1:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tboser did this have a purpose? Is the bugfix ok?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When creating a dataset for participants we don't want them to have particle barcodes attributed to all the hits, they will need to do that themselves using their reconstruction algorithm. I understood we'd give them a barcode for the first hit (that intersects the first detector), and they'd find all other hits they believe can be attributed to that particle (barcode). Most hits will have '?' for the barcode and they'll need to change that to a particle barcode. This will work so they could potentially return their solution in the format:
particle barcode 1, [hitbc1.1, hitbc2.1, hitbc3.1 etc]
particle barcode 2, [hitbc1.2, 2.2, 3.2 etc]

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's worth noting that my method also printed out all the barcodes if dataset == False

Copy link
Contributor

@dhrou dhrou Jan 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Thomas, actually we discussed this the other day. We can't give the first layer a special role, because : first layer hit might not be there because of inefficiency to be simulated, see (#9), or first layer hit might be merged between two tracks, see (#7).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand. In that case if you plan on generating datasets you won't be giving particle barcodes and the reconstruction algorithm will return sets of hits?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes exactly. I

@yetkinyilmaz yetkinyilmaz requested review from dhrou and tboser January 26, 2017 14:11
Generation of data, Reconstruction of Tracks and Analysis of
predictions are splitted into separate directories for more convenient
development in parallel.
@dhrou dhrou merged commit b2dc910 into LAL:master Jan 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants