Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup the codebase to make it easier to understand and use #11

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

HCA97
Copy link

@HCA97 HCA97 commented May 28, 2023

Hi,

Thank you for your amazing work.

Recently, I was working on NSFW detection and came across your repository. I found it challenging to use AutoKeras models due to the outdated packages required to run them, see issue-9. As a result, I decided to clean up the repository and transition to PyTorch, making it easier for others to utilize these models more effectively. Furthermore, I have added additional resources and documentation to enhance understanding and usability.

As an outsider, I am unsure of the meaning of all the files, such as safety_setting.yaml therefore I keep some of the old files in the .old folder. Additionally, some of the information I provided might be incorrect, for example, details about the training dataset in the readme.

Best Regards
HCA

@rom1504
Copy link
Contributor

rom1504 commented May 29, 2023

clip retrieval https://github.com/rom1504/clip-retrieval is depending on the model files being where they were so please don't merge as is

@HCA97
Copy link
Author

HCA97 commented May 30, 2023

Hi,

Thank you for your quick response and for pointing out the model files. I have now moved the model files back to their original location.

By the way, I don't want to cause any extra work for you. I know you guys have a lot going on. If you believe the changes to the repository are not needed and are unnecessary, please feel free to close the pull request. However, if you think the changes can be useful or find them necessary, and if there are still changes that need to be made, please let me know. I am happy to help.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants