Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make NewRequestWithContext more robust #63

Merged
merged 2 commits into from
Jul 11, 2024
Merged

Make NewRequestWithContext more robust #63

merged 2 commits into from
Jul 11, 2024

Conversation

hiepnv90
Copy link
Member

No description provided.

@hiepnv90 hiepnv90 requested a review from secmask July 11, 2024 09:01
@hiepnv90 hiepnv90 self-assigned this Jul 11, 2024
secmask
secmask approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@secmask secmask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hiepnv90 hiepnv90 merged commit 1f7d86e into main Jul 11, 2024
3 checks passed
@hiepnv90 hiepnv90 deleted the chore/make_new_http_request_more_robust branch July 11, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@secmask secmask secmask approved these changes

Assignees

@hiepnv90 hiepnv90

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hiepnv90 @secmask